Skip to content

Check missing translations on PRs#377

Open
simonaszilinskas wants to merge 5 commits into
developfrom
check-missing-translations
Open

Check missing translations on PRs#377
simonaszilinskas wants to merge 5 commits into
developfrom
check-missing-translations

Conversation

@simonaszilinskas

Copy link
Copy Markdown
Collaborator

Summary

  • Adds a GitHub Actions workflow that runs on PRs touching fr.json or en.json
  • Compares translation keys between French and Danish locale files
  • Posts a PR comment listing missing keys and tags the right people to translate them
  • Includes a temporary test key in fr.json to trigger the workflow on this PR (to remove after testing)

Test plan

  • Verify the workflow runs on this PR
  • Check the PR comment lists the missing _ci_test key for Danish
  • Remove the test key from fr.json after validation

Adds a test key to fr.json to trigger the workflow on this PR.
@github-actions

github-actions Bot commented Mar 6, 2026

Copy link
Copy Markdown
Contributor

Missing Translations

Danish (da.json) is missing 55 key(s) present in fr.json

@KennethEnevoldsen could you add the Danish translations for these keys?

  • generated.licenses.os.Modified MIT.license_desc
  • generated.models.Claude 4.6 Sonnet.desc
  • generated.models.Claude 4.6 Sonnet.fyi
  • generated.models.Claude 4.6 Sonnet.size_desc
  • generated.models.GLM 5.desc
  • generated.models.GLM 5.fyi
  • generated.models.GLM 5.size_desc
  • generated.models.GPT 5.3.desc
  • generated.models.GPT 5.3.fyi
  • generated.models.GPT 5.3.size_desc
  • generated.models.Gemini 3.1 Flash Lite.desc
  • generated.models.Gemini 3.1 Flash Lite.fyi
  • generated.models.Gemini 3.1 Flash Lite.size_desc
  • generated.models.Gemini 3.1 Pro.desc
  • generated.models.Gemini 3.1 Pro.fyi
  • generated.models.Gemini 3.1 Pro.size_desc
  • generated.models.Kimi K2.5.desc
  • generated.models.Kimi K2.5.fyi
  • generated.models.Kimi K2.5.size_desc
  • generated.models.MiniMax M2.5.desc
  • generated.models.MiniMax M2.5.fyi
  • generated.models.MiniMax M2.5.size_desc
  • generated.models.Odin Large.desc
  • generated.models.Odin Large.fyi
  • generated.models.Odin Large.size_desc
  • generated.models.Odin Medium.desc
  • generated.models.Odin Medium.fyi
  • generated.models.Odin Medium.size_desc
  • generated.models.Qwen 3.5 35B A3B.desc
  • generated.models.Qwen 3.5 35B A3B.fyi
  • generated.models.Qwen 3.5 35B A3B.size_desc
  • generated.models.Qwen 3.5 397B.desc
  • generated.models.Qwen 3.5 397B.fyi
  • generated.models.Qwen 3.5 397B.size_desc
  • generated.models.Qwen3 Coder Next.desc
  • generated.models.Qwen3 Coder Next.fyi
  • generated.models.Qwen3 Coder Next.size_desc
  • generated.models.Trinity Large.desc
  • generated.models.Trinity Large.fyi
  • generated.models.Trinity Large.size_desc
  • reveal.equivalent.co2.unit
  • reveal.equivalent.desc
  • reveal.equivalent.scales.baguette_production.tooltip
  • reveal.equivalent.scales.baguette_production.unit
  • reveal.equivalent.scales.mango_import.tooltip
  • reveal.equivalent.scales.mango_import.unit
  • reveal.equivalent.scales.one_year_tree_absortion.tooltip
  • reveal.equivalent.scales.one_year_tree_absortion.unit
  • reveal.equivalent.scales.package_delivery.tooltip
  • reveal.equivalent.scales.package_delivery.unit
  • reveal.equivalent.scales.paris_nyc_flights.tooltip
  • reveal.equivalent.scales.paris_nyc_flights.unit
  • reveal.equivalent.scales.pool_filing.tooltip
  • reveal.equivalent.scales.pool_filing.unit
  • reveal.equivalent.title_tooltip

French (fr.json) is missing 4 key(s) present in da.json

@simonaszilinskas could you add the French translations for these keys?

  • reveal.equivalent.lightbulb.label
  • reveal.equivalent.lightbulb.tooltip
  • reveal.equivalent.streaming.label
  • reveal.equivalent.streaming.tooltip

@simonaszilinskas

Copy link
Copy Markdown
Collaborator Author

Added the missing translations on Weblate

@KennethEnevoldsen

Copy link
Copy Markdown
Contributor

Most of these keys are empty:

Screenshot 2026-03-06 at 17 49 27 Screenshot 2026-03-06 at 17 49 50

Is it possible to mark it as "translated" on my side? I went through them to see if there was any non-empty and found a few these are now translated

@simonaszilinskas

Copy link
Copy Markdown
Collaborator Author

should work better now ! made it ignore the keys that are empty

@Axolotle

Axolotle commented Mar 9, 2026

Copy link
Copy Markdown
Collaborator

Some notes about this:

  • newly translations would not be available in weblate before it is merged into develop, so this can hint you that there will be new things to translate soon but not much.
  • we should not find missing keys in french since it is still the default (in that case, missing keys in fr means that those are no longer used, therefor have to be deleted in other languages)

So maybe the idea is to slow down the deployment so that when new content is merged into develop, you have enough time to translate it. We could also not merge PR that needs translation and let you translate directly by hand without weblate.

@simonaszilinskas

Copy link
Copy Markdown
Collaborator Author

@Axolotle good point!

Maybe we can implement the check before merging to main instead? I think the most important thing is to let the Danish partners know when it's good to go and then also merge the updated translations quite quickly.

Run the translation check on PRs targeting main instead of develop,
so translators get notified at deploy time. Compare all locale files
(not just Danish), and flag keys missing from fr.json as obsolete
rather than requesting French translations.
@KennethEnevoldsen

Copy link
Copy Markdown
Contributor

Yeah, I will typically be able to have the translation with a day or two, and we can set it up so there is one additional person that can take over if I am on holiday or similar

@KennethEnevoldsen

Copy link
Copy Markdown
Contributor

@simonaszilinskas any status on this - I would love to get this merge in as we still see non-translated text on the Danish leaderboard, which makes it a bit hard for us to promote it properly

Screenshot 2026-06-30 at 15 25 59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

3 participants