Check missing translations on PRs#377
Conversation
Adds a test key to fr.json to trigger the workflow on this PR.
Missing TranslationsDanish (
|
|
Added the missing translations on Weblate |
|
should work better now ! made it ignore the keys that are empty |
|
Some notes about this:
So maybe the idea is to slow down the deployment so that when new content is merged into develop, you have enough time to translate it. We could also not merge PR that needs translation and let you translate directly by hand without weblate. |
|
@Axolotle good point! Maybe we can implement the check before merging to main instead? I think the most important thing is to let the Danish partners know when it's good to go and then also merge the updated translations quite quickly. |
Run the translation check on PRs targeting main instead of develop, so translators get notified at deploy time. Compare all locale files (not just Danish), and flag keys missing from fr.json as obsolete rather than requesting French translations.
|
Yeah, I will typically be able to have the translation with a day or two, and we can set it up so there is one additional person that can take over if I am on holiday or similar |
|
@simonaszilinskas any status on this - I would love to get this merge in as we still see non-translated text on the Danish leaderboard, which makes it a bit hard for us to promote it properly
|



Summary
fr.jsonoren.jsonfr.jsonto trigger the workflow on this PR (to remove after testing)Test plan
_ci_testkey for Danishfr.jsonafter validation