Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 30 additions & 35 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,47 +1,42 @@
## Resubmission

This is a resubmission. Compared to the previously submitted version (2.1.0):

- I replaced the `\\dontrun{}` example for `extract_mfcc()` with a fast,
executable example. It creates a short WAV file under `tempdir()`, guards the
optional `tuneR` dependency with `requireNamespace()`, and removes the file
after use.
- I unwrapped the short `phontrast()` and `hier_boot_jsd_model()` bootstrap
examples after measuring them below five seconds. I also reduced the
illustrative `estimate_jsd()` bootstrap count from 50 to 10, bringing that
example below five seconds so it could be unwrapped. No examples now use
`\\dontrun{}` or `\\donttest{}`.
- I removed direct access to `.GlobalEnv` and `.Random.seed`. Seeded internal
sampling now uses a private deterministic generator, so `eval_seed` remains
reproducible without modifying the user's workspace or RNG stream.
- Versions 2.2.0 and 2.3.0 added a multivariate-normal density backend and
distribution-aware plotting, respectively. Version 2.3.1 contains the CRAN
review fixes above; the previously published GitHub tags remain unchanged.

## Submission

This is a new submission (first time on CRAN). `phontrast` is a rename and
reframing of the previously GitHub-only package `phonJSD` (released through
v1.2.0). Development, testing, and documentation were assisted by AI tools, as
disclosed in the README; all design, analysis, and release decisions were made
by the maintainer.
This is an update to the CRAN release `phontrast` 2.3.1.

Version 2.4.0 is being submitted three days after 2.3.1 because it corrects
release metadata that users currently see: the GitHub 2.4.0 tag initially
retained `Version: 2.3.1`, and the package citation remained frozen at version
2.0.0. The tag, package version, NEWS, version-specific Zenodo DOI, and
version-aware package citation are now consistent.

## Changes

- Added the opt-in proportion-standardized Pillai estimates documented in
`NEWS.md`; existing defaults and the original return fields are unchanged.
- Corrected the package version metadata to 2.4.0.
- Replaced the stale citation with a version-aware citation for Grant M. Berry
and the 2.4.0 Zenodo DOI <doi:10.5281/zenodo.21864533>.
- Added tests that keep the installed citation version and DOI synchronized
with `DESCRIPTION`.

## Test environments

- Local: macOS 26.5.2 (aarch64-apple-darwin23), R 4.6.1,
`R CMD check --as-cran --no-manual`
- GitHub Actions: Ubuntu latest, R release, `R CMD check`

## R CMD check results

0 errors | 0 warnings | 0 notes
0 errors | 0 warnings | 1 note

The sole note is the expected incoming-check note:

```
Days since last update: 3
```

## Notes for the reviewer
The unusually short interval is necessary to correct the public package
version and citation metadata described above.

* The spell-check flags domain terminology in the Description and
documentation (e.g. "Bhattacharyya", "Mahalanobis", "Pillai", "MFCCs",
"sociophonetics", "phonological"). These are standard terms from phonetics
and multivariate statistics; they are listed in `inst/WORDLIST`.
* The `Description` cites Lin (1991) <doi:10.1109/18.61115> for the
Jensen-Shannon divergence.
* `ggplot2`, `mgcv`, and `tuneR` are used only conditionally
(`requireNamespace()`), so they are in Suggests rather than Imports.
The local PDF-manual check could not run because the local TeX installation is
missing `inconsolata.sty`. All Rd checks, examples, tests, vignettes, and the
HTML manual check completed successfully.
1 change: 0 additions & 1 deletion inst/CITATION
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
meta <- packageDescription("phontrast")
version <- meta[["Version"]]

version_dois <- c(
Expand Down