Fix v2.4.0 package metadata - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
DESCRIPTIONfrom version 2.3.1 to 2.4.0DESCRIPTIONRoot cause
The 2.4.0 feature work and NEWS entry were released without updating the package version in
DESCRIPTION. Bothv2.4.0and2.4.0therefore pointed to source that installed as version 2.3.1.After this PR is merged, both existing 2.4.0 tag refs will be moved from
9467c82to the corrected merge commit. The existing GitHub release will be retained and its notes updated with the repair.User impact
Installing
berrygrant/phontrast@v2.4.0will report package version 2.4.0, matching the tag, release, and NEWS.Validation
v2.4.0and2.4.0R CMD build .producedphontrast_2.4.0.tar.gzR CMD check --no-manual phontrast_2.4.0.tar.gz— Status: OKgit diff --check