Skip to content

[upstream #16487] InputNumber's disabled classes never match the rc-input-number wrapper #200

Closed

Description

@berry-13

Found while extending the disabled fill recipe in LibreChat-AI#16487.

packages/client/src/components/InputNumber.tsx puts its classes on rc-input-number's wrapper div, but the disabled state lives on the nested <input>; the wrapper only gains an rc-input-number-disabled class. So the component's disabled:opacity-50 has never matched: a disabled InputNumber does not dim in any theme today, and the theme-disabled: recipe (disabledFillClasses) cannot reach it either, which is why LibreChat-AI#16487 leaves it out.

Gap: make the disabled state reach the wrapper (for example a data-disabled attribute or state classes derived from props.disabled), so both the default dim and a fill theme's disabled roles apply. This changes the default theme's disabled InputNumber from undimmed to dimmed, so it needs its own before/after check.

Activity

  1. added
    bugSomething isn't working
    readyreviewctl followups state
    and removed on Sep 29, 2026
  2. added
    fixedreviewctl followups state
    and removed
    readyreviewctl followups state
    on Oct 7, 2026
  3. berry-13 commented on Oct 7, 2026

    @berry-13
    OwnerAuthor

    Closed by reviewctl followups sync: LibreChat-AI#16820 merged on 2026-10-06 at e034484.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: packagesreviewctl followups statebugSomething isn't workingfixedreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions