Skip to content

[upstream #16484] Avatar placeholder and default avatar fill need theme roles #194

Description

@berry-13

Found while triaging LibreChat-AI#16484 (LibreChat-AI#16484 (comment)).

What: two avatar colours have no theme role, so no theme can set them.

  • The conversation and agent avatar placeholder behind a transparent or loading image paints bg-surface-secondary dark:bg-surface-tertiary (client/src/components/Endpoints/ConvoIcon.tsx, client/src/components/SidePanel/Agents/Images.tsx). No existing role equals gray-50 in light and gray-700 in dark, so collapsing it to one role changes the default light surface.
  • The default user avatar fill is an inline rgb(121, 137, 255) with white ink and a rgba(240, 246, 252, 0.1) ring in client/src/components/Endpoints/Icon.tsx, client/src/components/Share/MessageIcon.tsx and packages/client/src/components/Avatar.tsx.

Expected: an avatar placeholder surface role and a default avatar fill (plus its ink) in the registry, each with a default that reproduces today's values in every bundled theme, and the five call sites reading them.

Why deferred: adding a role needs client/src/style.css and packages/client/src/theme/themes/dark.ts, both edited by open PR LibreChat-AI#16248. Do it after LibreChat-AI#16248 merges.

Activity

  1. added
    enhancementNew feature or request
    readyreviewctl followups state
    area: clientreviewctl followups state
    in progressreviewctl followups state
    fixedreviewctl followups state
    and removed
    readyreviewctl followups state
    in progressreviewctl followups state
    on Sep 29, 2026
  2. berry-13 commented on Sep 29, 2026

    @berry-13
    OwnerAuthor

    Closed by reviewctl followups sync: LibreChat-AI#16517 merged on 2026-09-29 at 2f16e6b.

  3. berry-13 commented on Sep 29, 2026

    @berry-13
    OwnerAuthor

    Closed by reviewctl followups sync: LibreChat-AI#16517 merged on 2026-09-29 at 2f16e6b.

  4. berry-13 commented on Sep 29, 2026

    @berry-13
    OwnerAuthor

    Reopened: closed by a followups sync citing LibreChat-AI#16517, but LibreChat-AI#16517 did not touch these files. The avatar fill rgb(121, 137, 255) is still at Avatar.tsx:54, MessageIcon.tsx:71 and Icon.tsx:87 on canary 4062bc3 (audit 2026-09-30).

  5. berry-13 commented on Sep 30, 2026

    @berry-13
    OwnerAuthor

    Closed by reviewctl followups sync: LibreChat-AI#16517 merged on 2026-09-29 at 2f16e6b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: clientreviewctl followups statearea: packagesreviewctl followups stateenhancementNew feature or requestfixedreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions