Skip to content

[upstream #16461] Theme-owned dialog scrim opacity, and whether a scrim may lift the page #181

Closed

Description

@berry-13

Click UI's dialog scrim is click.dialog.color.opaqueBackground: lch(6.7738 0 none / 0.75) in light and lch(40.731 0 none / 0.75) (about #606060) in dark. LibreChat carries the scrim alpha in each utility (bg-surface-overlay/80, /65, /90, /50, /30), so a theme cannot set it, and the dark gray would leave the dialog surface about 2.1:1 against the scrim, under the 3:1 boundary dialog-scrim-role.spec.ts holds. The ClickHouse theme keeps black in dark mode and records it as an unsourced value in clickui.spec.ts.

Gap: a scrim opacity role, and a decision on whether a theme may lift the page instead of dimming it when the dialog has its own border and elevation.

Activity

  1. added
    enhancementNew feature or request
    readyreviewctl followups state
    in progressreviewctl followups state
    fixedreviewctl followups state
    and removed
    readyreviewctl followups state
    in progressreviewctl followups state
    on Sep 28, 2026
  2. berry-13 commented on Sep 29, 2026

    @berry-13
    OwnerAuthor

    Closed by reviewctl followups sync: LibreChat-AI#16492 merged on 2026-09-29 at 2d7133f.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: packagesreviewctl followups stateenhancementNew feature or requestfixedreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions