Skip to content

[upstream #16262] #16262: the mobile drawer has no 3:1 boundary against its scrim in dark mode #145

Description

@berry-13

Raised on LibreChat-AI#16262 (LibreChat-AI#16262 (comment)), split from #105, which raised the mobile scrim to the dialogs' 80% and fixed both light palettes.

In dark mode no scrim opacity separates the mobile drawer (surface-primary-alt) from the conversation behind the scrim by the 3:1 a boundary needs. The overlay is already black in both dark palettes and the drawer itself is near-black, so even a fully opaque scrim tops out at 1.17:1 (LibreChat) and 1.42:1 (ClickHouse).

Drawer against the page composited under the scrim:

Palette 50% 70% 80% 100%
LibreChat light 2.12 3.18 4.01 6.54
ClickHouse light 2.15 3.26 4.09 6.77
LibreChat dark 1.06 1.10 1.12 1.17
ClickHouse dark 1.29 1.35 1.37 1.42

Expected: the drawer gets an edge of its own in dark mode (a border role with 3:1 against surface-primary-alt), which belongs on the drawer container in client/src/components/UnifiedSidebar/UnifiedSidebar.tsx.

Sequencing: the surface is already on canary, so this does not depend on the root PR, but it waits on LibreChat-AI#16248, the open drawer PR that owns UnifiedSidebar.tsx. Start it after LibreChat-AI#16248 merges and extend the mobile-drawer-scrim scenarios to measure dark as well.

Activity

  1. added
    readyreviewctl followups state
    a11yreviewctl followups state
    area: clientreviewctl followups state
    on Sep 25, 2026
  2. berry-13 commented on Sep 29, 2026

    @berry-13
    OwnerAuthor

    Tracked in #199: the theme scrim role landed in LibreChat-AI#16492, and the drawer consumer waits on LibreChat-AI#16248, which owns UnifiedSidebar/**.

  3. added
    in progressreviewctl followups state
    fixedreviewctl followups state
    and removed
    readyreviewctl followups state
    in progressreviewctl followups state
    on Oct 1, 2026
  4. berry-13 commented on Oct 1, 2026

    @berry-13
    OwnerAuthor

    Closed by reviewctl followups sync: LibreChat-AI#16248 merged on 2026-10-01 at 0da8987.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a11yreviewctl followups statearea: clientreviewctl followups statefixedreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions