Skip to content

[upstream #16245] #16245: Inject the shared-links setting into the conversation methods #130

Description

@berry-13

From LibreChat-AI#16245 (local cross-family review on 05569a9, finding L-003).

getSharedConversationIds and the existing attachSharedFlags in packages/data-schemas/src/methods/conversation.ts both read process.env.ALLOW_SHARED_LINKS inside the data-schemas method. Per the workspace rule that backend modules take their dependencies, the effective sharing setting should be passed in by the caller (for example through createConversationMethods deps), so the methods can be tested and reused without process-global state. Both functions should move together.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: packagesreviewctl followups statereadyreviewctl followups staterefactorreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions