Skip to content

PR #15684 — Project file failures show untranslated server reasons (discussion_r3962007029) #13

Closed

Description

@berry-13

Deferred residual from upstream PR LibreChat-AI#15684 (head 2dbd5e7e63).
Finding: LibreChat-AI#15684 (comment)

What happens

When attaching a file to a Chat Project fails, the failed row renders the server's reason verbatim:

// client/src/components/Projects/ProjectResources.tsx
const associationError = responseData && 'error' in responseData ? responseData.error : undefined;
return typeof associationError === 'string' && associationError.trim().length > 0
  ? associationError
  : localize('com_error_files_upload');

Showing the real reason is the point — a capacity race, an expired file or a deleted project each explain a retry that will not succeed, and the generic upload error does not. But those strings come from packages/api/src/projects/handlers.ts in English (Project file limit reached, Project not found), so a user on a non-English locale gets one English line in an otherwise localized surface. Only the fallback is localized.

Suggested direction

Give the project file endpoints a small stable reason code alongside the message and map codes to localized strings on the client, keeping the server string as the fallback for unknown codes. That keeps the diagnostic value without shipping untranslated UI text.

Activity

  1. berry-13 commented on Sep 29, 2026

    @berry-13
    OwnerAuthor

    Fixed in the root PR at LibreChat-AI/LibreChat@ebb02b14c3 (association failures show localized messages, never server text), verified on head 2f79ee5. Closes when LibreChat-AI#15684 merges.

  2. added
    readyreviewctl followups state
    and removed on Sep 30, 2026
  3. berry-13 commented on Oct 8, 2026

    @berry-13
    OwnerAuthor

    Fixed on dev (852e004): client/src/components/Projects/ProjectResources.tsx:75-83 getAssociationErrorMessage only shows localized strings (com_ui_project_file_limit, com_ui_project_file_attach_error); landed in ebb02b1 (LibreChat-AI#15684).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area: clientreviewctl followups statearea: packagesreviewctl followups statebugSomething isn't workingreadyreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions