Skip to content

[upstream #16262] #16262: the mobile drawer scrim at 50% does not separate the drawer by 3:1 in any palette #105

Description

@berry-13

Raised on LibreChat-AI#16262 (LibreChat-AI#16262 (comment)).

The mobile drawer's dismiss target (client/src/components/UnifiedSidebar/mobile/Scrim.tsx) paints bg-surface-overlay/50 next to the drawer's surface-primary-alt, and at that fixed 50% opacity no palette separates the two by the 3:1 a boundary needs. Composited over the page: LibreChat default light 2.12:1, default dark 1.00:1, ClickHouse light 2.15:1, ClickHouse dark 1.30:1. The shared dialogs use the same role at 80% and clear the floor, which e2e/specs/mock/scenarios/dialog-scrim-role.spec.ts pins.

Suggested direction: raise the mobile scrim's opacity to the dialogs' 80% (or give the drawer an edge of its own), and add a scenario that measures the drawer against its scrim in light and dark.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    a11yreviewctl followups statearea: clientreviewctl followups statefixedreviewctl followups state

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions