Prevent LEDs from quickly blinking when on_time == 0 or off_time == 0 - #1
Open
markopetrovi wants to merge 1 commit into
Open
Prevent LEDs from quickly blinking when on_time == 0 or off_time == 0#1markopetrovi wants to merge 1 commit into
markopetrovi wants to merge 1 commit into
Conversation
In some programs a situation when, under certain conditions, LEDs should blink, while in other conditions they should be in the same state (on or off) all the time can appear. In the current code even in situation when on_time or off_time are 0, LEDs would briefly change states (first to the state with time 0 and then back on the next call to updateBlinkLed()).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some programs a situation when, under certain conditions, LEDs should blink, while in other conditions they should be in the same state (on or off) all the time can appear. In the current code even in situation when on_time or off_time are 0, LEDs would briefly change states (first to the state with time 0 and then back on the next call to updateBlinkLed()).