Post-release: bump to 5.0.5-SNAPSHOT#292
Merged
Merged
Conversation
5.0.4 is released on Maven Central. Open the next development cycle: bump all three reactor poms (llama-parent + llama + llama-langchain4j <parent><version>) to 5.0.5-SNAPSHOT and point the README snapshot dependency examples at 5.0.5-SNAPSHOT. The release dependency examples stay at the just-released 5.0.4. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QEgh6vtcPWAgQ6scK8pJk7
bernardladenthin
temporarily deployed
to
startgate
GitHub Actions
Inactive
|
Review complete. Found one missed snapshot version in the module README. |
|
File llama-langchain4j/README.md line 65 still has 5.0.4-SNAPSHOT and should be updated to 5.0.5-SNAPSHOT for consistency. |
… -SNAPSHOT) The llama-langchain4j section shows a single "how to depend on it" snippet, the analogue of the core's Quick Start release example (5.0.4) — not a snapshot example (the core has a separate Snapshot-builds snippet for that). It was mistakenly carrying -SNAPSHOT, and the post-release snapshot bump then propagated it to 5.0.5-SNAPSHOT. Pin it to the released 5.0.4, matching the core release example; the only -SNAPSHOT in the README is now the core snapshot snippet. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QEgh6vtcPWAgQ6scK8pJk7
bernardladenthin
temporarily deployed
to
startgate
GitHub Actions
Inactive
|
✅ Review passed This PR correctly opens the post-release development cycle after 5.0.4: Verified:
No issues found. The changes are minimal, correct, and well-explained. Ready to merge. |
The module README's "## Dependency" section is its primary usage snippet (no separate snapshot snippet), so it should show the released version like the root README's core Quick Start. It was carrying -SNAPSHOT and shipped that way in 5.0.4. Unlike the root README it is not touched by the release/snapshot version bumps, so it had drifted silently. Pin to 5.0.4. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QEgh6vtcPWAgQ6scK8pJk7
bernardladenthin
temporarily deployed
to
startgate
GitHub Actions
Inactive
Review FindingsThe PR correctly bumps the version from 5.0.4 to 5.0.5-SNAPSHOT across all three reactor poms in lockstep:
README examples correctly updated:
Single clean commit, fast-forward from main@5.0.4 as described. No blocking issues found — ready to merge. |
The maintainer release procedure predated the llama/ reactor split and was
stale in four ways, each of which just bit this 5.0.4 release:
- "Strip -SNAPSHOT from pom.xml" (singular) -> the version now lives in all
three reactor poms (root <version> + both <parent><version>); use
`mvn versions:set` so they move in lockstep or the reactor build fails.
- No CHANGELOG step -> add finalizing [Unreleased] -> [VERSION] + compare links.
- No mention of llama-langchain4j/README.md's release dependency snippet, which
is not covered by the root-README edits and drifted silently.
- "commit directly to main (no PR)" -> use a branch + PR, and spell out the
actual deploy trigger (workflow_dispatch + publish_to_central=true on a v* tag).
Add a {PREV} placeholder for the CHANGELOG compare link.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QEgh6vtcPWAgQ6scK8pJk7
bernardladenthin
temporarily deployed
to
startgate
GitHub Actions
Inactive
Review: Version inconsistency in llama-langchain4j/README.mdI found a critical inconsistency in this PR. The change to llama-langchain4j/README.md is incorrect: Current change in the diff: - <version>5.0.4-SNAPSHOT</version>
+ <version>5.0.4</version>The problem:
Expected change: - <version>5.0.4-SNAPSHOT</version>
+ <version>5.0.5-SNAPSHOT</version>According to CLAUDE.md (Version bump section), when bumping after a release:
Since llama-langchain4j/README.md line 65 is in a "Dependency" section (snapshot context), it should use 5.0.5-SNAPSHOT, not 5.0.4. |
…upplement The maintainer release procedure is now centralized in workspace/workflows/release-process.md. Replace this repo's standalone copy with a pointer to it plus the two java-llama.cpp-specific supplements: the reactor all-three-poms version bump (via mvn versions:set) and the extra llama-langchain4j/README.md release dependency snippet. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QEgh6vtcPWAgQ6scK8pJk7
bernardladenthin
temporarily deployed
to
startgate
GitHub Actions
Inactive
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
5.0.4 is released on Maven Central. This opens the next development cycle.
Changes
5.0.5-SNAPSHOT, in lockstep:pom.xml(root) —<version>llama/pom.xml—<parent><version>llama-langchain4j/pom.xml—<parent><version>5.0.5-SNAPSHOT.5.0.4.Notes
main@ 5.0.4 — single commit, fast-forwards cleanly.<parent><version>literals are not single-sourced; changing root alone would fail the reactor build).🤖 Generated with Claude Code
https://claude.ai/code/session_01QEgh6vtcPWAgQ6scK8pJk7
Generated by Claude Code