Reimplement lost platformVersion window prop#458
Open
johnnycrich wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Reintroduces the window.platformVersion global in the Flutter web entrypoint to fix the app sidebar displaying the version as null, after it was removed during the Flutter web bootstrap refactor in #388.
Changes:
- Re-adds
window.platformVersion = "__VERSION__";inclient/web/index.htmlso the web client can read and render the version string. - Runs an HTML auto-format pass (doctype casing, indentation, attribute wrapping) while keeping existing loading behavior intact.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| body { | ||
| margin: 0; | ||
| padding: 0; | ||
| /* Prevent body scroll, allow Fltter to handle it internally.*/ |
| </script> | ||
|
|
||
| <script> | ||
| if (window.location.hostname == "localhost") { |
|
Visit the preview URL for this PR (updated for commit 5594c56): https://gen-hls-bkc-7627--pr458-440-app-version-appe-zrvv6w93.web.app (expires Wed, 10 Jun 2026 21:42:36 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: eed668cca81618d491d024574a8f8a6003deaa8d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is in this PR?
Resolve version number appearing as
nullin the app sidebar.Changes in the codebase
./client/web/index.html:window.platformVersionas__VERSION__, which was accidentally lost in Issue 310: Implement Flutter Web accessibility improvement workaround #388.Testing this PR
Open sidebar and see that app version is visible (Github
SHAon preview build,__VERSION__on local).