Skip to content

Fix agenda timer card to display hours correctly#435

Open
johnnycrich wants to merge 3 commits into
stagingfrom
367-meeting-section-timer-rolls-over-after-1h
Open

Fix agenda timer card to display hours correctly#435
johnnycrich wants to merge 3 commits into
stagingfrom
367-meeting-section-timer-rolls-over-after-1h

Conversation

@johnnycrich
Copy link
Copy Markdown
Contributor

@johnnycrich johnnycrich commented May 13, 2026

What is in this PR?

A minor UI fix to the meeting guide card for the display of an agenda item's remaining time, closing #367.

Changes in the codebase

In _MeetingGuideCardState:

  • Increase the width of the container displaying the agenda item's time to accommodate longer time formats.
  • Updated the logic for formatting the remaining time so that hours are shown if the time remaining is greater than zero hours.

Testing this PR

  • Start a meeting and set an agenda section to a short time (e.g. 10 sec)
  • Observe the timer counting down in min:sec.
  • Stay in that section without "continuing" for more than 1 hour past time (sorry)
  • Observe the timer counting down in hours:min:sec.

@johnnycrich johnnycrich added the bug Something isn't working as intended label May 13, 2026
@johnnycrich johnnycrich linked an issue May 13, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the live meeting guide card timer display so agenda item remaining time can include an hours component when needed.

Changes:

  • Expands the timer container width to fit longer time strings.
  • Changes remaining-time formatting to conditionally show hours.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 13, 2026

Visit the preview URL for this PR (updated for commit 183d2fd):

https://gen-hls-bkc-7627--pr435-367-meeting-section-cxqmlj6f.web.app

(expires Wed, 10 Jun 2026 18:02:15 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: eed668cca81618d491d024574a8f8a6003deaa8d

@katherineqian
Copy link
Copy Markdown
Collaborator

Hey @johnnycrich, thanks for this fix! Unfortunately I tested on the staging link and the behavior doesn't seem to be fixed -- see below screenshots:

  1. An hour has almost passed!
Screenshot 2026-05-15 at 14 29 26
  1. Observe that the timer still rolls over, and the URL is the staging preview link.
Screenshot 2026-05-15 at 14 29 36

Copy link
Copy Markdown
Collaborator

@katherineqian katherineqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes as in above comment.

@johnnycrich
Copy link
Copy Markdown
Contributor Author

@katherineqian This should be all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meeting section timer rolls over after 1h.

3 participants