Enhance use-outside-click.ts Hook with Strict Typing for Events and Callback. - #2
Open
vignesh1507 wants to merge 1 commit into
Open
Enhance use-outside-click.ts Hook with Strict Typing for Events and Callback.#2vignesh1507 wants to merge 1 commit into
vignesh1507 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes that i have made to the code are as follows:
Typed callback and event: I replaced the
anytype withMouseEvent | TouchEventfor the event and provided a more specific type for thecallbackfunction.event.target as Node: Since
event.targetis of typeEventTarget, which may not directly contain DOM manipulation methods, casting it to Node ensures thecontains()method is correctly interpreted by TypeScript.