Fix stale keyboard path in Dockerfile default CMD - #4
Draft
benjamingehl wants to merge 1 commit into
Draft
Conversation
The default CMD still targeted gmmk/pro, which stopped resolving once DEFAULT_FOLDER support for the GMMK Pro was removed from QMK (the compose service was already updated to gmmk/pro/rev1/ansi in 2dd8c05, but this fallback CMD was missed). Reviewed the repo against the current QMK breaking-changes changelog, QMK CLI docs, and pinned GitHub Actions versions: keycodes (RM_*, SC_LSPO/SC_RSPC), ENCODER_MAP usage, rules.mk feature flags, and the build.yml action versions are all already current — no other changes needed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X5WCd4v4ZtphKVBBcqb1L6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scheduled maintenance pass: checked dependencies, QMK breaking changes, API deprecations, and GitHub Actions versions against current upstream state.
Dockerfile's defaultCMD, which still targetedgmmk/pro. That path stopped resolving onceDEFAULT_FOLDERsupport for the GMMK Pro was removed from QMK — thedocker-compose.yamlservice was already updated togmmk/pro/rev1/ansiin a prior commit (2dd8c05), but this fallbackCMD(only used for a baredocker runwithout compose) was missed at the time.Findings from the audit (no changes needed)
actions/checkout@v7,docker/setup-buildx-action@v4,docker/build-push-action@v7,actions/github-script@v9,actions/upload-artifact@v7are all still the current major versions.keymap.care already current (RM_*matrix keycodes,SC_LSPO/SC_RSPCSpace Cadet,ENCODER_MAPinstead of the removedencoder_update_kb/usercallbacks). No affected macros inrules.mk/config.h(RGB_MATRIX_*,CAPS_WORD,AUTOCORRECT,VIA_ENABLE,DEBOUNCE_TYPE) were touched by upstream.pipx install qmk+qmk setup -yremains a working install path; QMK's docs now lead with acurl | shbootstrapper aimed at end-user machines, but it isn't a deprecation of the pipx flow and isn't a better fit for this Docker build, so left as-is.ubuntu:24.04is still supported (LTS until 2029); no need to move to 26.04 for this use case.Test plan
Build firmwareworkflow) compiles successfully viadocker-compose.yaml(unaffected by this change, path was already correct there)CMDwasn't possible in this sandbox (outbound TLS from inside the Docker container is blocked by the sandbox's egress proxy), so this relies on CI to confirm the image still builds end-to-end.🤖 Generated with Claude Code
https://claude.ai/code/session_01X5WCd4v4ZtphKVBBcqb1L6
Generated by Claude Code