Fix handling of integer special variables#279
Merged
Conversation
BEGIN { NR = "x"; print NR }
GoAWK prints "0" instead "x" because we store integer special variables
like NR and FNR as Go ints. To fix, we should store as AWK value types.
This is just a draft to fix NR and FNR, but all the others (at least
integer ones?) need to be fixed as well.
benhoyt
force-pushed
the
fix-special-values
branch
from
47f3448 to
58eb9a6
Compare
benhoyt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if you do something like:
GoAWK prints "0" instead "x" because we store integer special variables like NR and FNR as Go ints. To fix, we should store as AWK value types.