fix(#1): [$20 BOUNTY] [Python] Make clean_module report failed clean #8
Open
Notime02 wants to merge 1 commit into
Open
fix(#1): [$20 BOUNTY] [Python] Make clean_module report failed clean #8Notime02 wants to merge 1 commit into
Notime02 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
The fix involves updating the clean_module function to check the return code of the subprocess command. If the return code is non-zero, it will print an error message including the module name and any available stdout/stderr output, and return False. This ensures that failed clean commands are reported correctly while preserving existing behavior for successful commands.
Otomatik oluşturulmuştur.