Repository navigation
Fix forward bind addresses and cancellation during SSH setup - #181
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local forwards displayed the saved bind address but always listened on 127.0.0.1. Stopping during SSH authentication could later reactivate the tunnel, including across logout. This change binds the configured address, cancels setup before it completes, and rejects results from stopped or replaced attempts. Workers keep their runtime alive for bounded listener/channel cleanup and remote cancellation before disconnecting SSH.
Validation: 859 unique workspace tests passed, including real SSH echo on a configured IPv6 bind and cancellation/retry ownership. Workspace Clippy with all targets and warnings denied, formatting, UI check and Linux build passed. Native Linux QA reproduced the original bugs and verified local, reverse and SOCKS traffic, delayed cancellation, stop/retry and logout. The QA report includes 12 screenshots and socket observations:
docs/testing/forward-qa-2026-09-30.md.Native macOS/Windows GUI and rendered click automation remain untested; signing is unchanged.