Skip to content

Send selected review comments to the authorized session #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benfavre merged 3 commits into from
Aug 29, 2026
Merged

Send selected review comments to the authorized session #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2446a93
chore(platform): move the protocol pin onto the review capability con…
benfavre Aug 29, 2026
e7c94a8
feat(review): send selected review comments to the authorized session
benfavre Aug 29, 2026
0acc6b3
docs(testing): record the capability-fenced batch delivery lane
benfavre Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ sha2 = "0.10"
base64 = "0.22"
ed25519-dalek = "2"
criterion = "0.5"
automonique-platform-client = { git = "https://github.com/bext-stack/automonique", rev = "c1e772e37371ba00825923f8f35ffc652c0a4e95" }
automonique-protocol = { git = "https://github.com/bext-stack/automonique", rev = "c1e772e37371ba00825923f8f35ffc652c0a4e95" }
automonique-platform-client = { git = "https://github.com/bext-stack/automonique", rev = "7d2fad53558ccb38ef3fdb12945974f75a0e73ce" }
automonique-protocol = { git = "https://github.com/bext-stack/automonique", rev = "7d2fad53558ccb38ef3fdb12945974f75a0e73ce" }
windows-sys = { version = "0.60", features = [
"Win32_Foundation",
"Win32_Security",
Expand Down
10 changes: 8 additions & 2 deletions crates/shelldeck-core/locales/en.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,7 +1217,12 @@ fleet.review.note_delete = "Delete"
fleet.review.note_stale = "Superseded snapshot"
fleet.review.note_failed = "The anchored note could not be stored."
fleet.review.save_note = "Save the note"
fleet.review.batch_blocked = "%{count} note(s) selected and retained. Batch delivery to the authorized session stays unavailable: the server advertises no capability for that action."
fleet.review.notes_selected = "%{count} note(s) selected and retained. A note is a local draft: prepare it as a comment before it can be delivered to the authorized session."
fleet.review.prepare_batch_send = "Send %{count} comment(s) to the session"
fleet.review.delivery_withheld_title = "Batch delivery unavailable"
fleet.review.delivery_withheld_no_server_capability = "No capability response is attributed to this project, workspace and snapshot revision: nothing was advertised, so no send control is offered."
fleet.review.delivery_withheld_no_deliverable_comment = "The server advertises no deliverable comment for this snapshot: no authorized session is bound to it, or no comment is in a sendable state. The advertisement is re-read on every refresh, including after a send."
fleet.review.delivery_withheld_no_custody_lane = "Durable custody is unavailable in this process: no batch send control is offered."
fleet.review.attention_title = "Attention chronology"
fleet.review.confirm_comment = "In project %{project}, workspace %{workspace}: add “%{body}” on %{file} · %{hunk} · %{side}:%{line}, from exact snapshot %{revision}."
fleet.review.confirm_approval = "In project %{project}, workspace %{workspace}: approve review rev %{review_revision}, from exact snapshot %{revision}."
Expand All @@ -1233,6 +1238,7 @@ fleet.review.pending_detail = "Action dispatched once; later attempts only look
fleet.review.invalid_preview = "The action no longer matches the exact active review."
fleet.review.never_dispatched = "The preview prepared before restart was never sent."
fleet.review.capability_stale = "The rerun capability changed; refresh and confirm a new preview."
fleet.review.delivery_capability_stale = "The delivery advertisement changed; reload, then prepare a new selection."
fleet.review.custody_failed = "Durable custody refused dispatch; no provider call started."
fleet.review.receipt_actor = "%{detail} · actor %{actor}"
fleet.review.receipt_actor_short = "actor %{actor}"
Expand All @@ -1244,7 +1250,7 @@ fleet.review.lane_partial = "partially staged"
fleet.review.staging_proposed = "%{action} · proposal %{id}"
fleet.review.staging_blocked = "%{action} · blocked · proposal %{id}"
fleet.review.staging_withheld_title = "Staging is read-only"
fleet.review.staging_withheld_no_server_capability = "The server advertises no staging capability for this snapshot: Platform v2 publishes only the check rerun. Staged, unstaged, untracked and conflict state stay visible, with no staging control."
fleet.review.staging_withheld_no_server_capability = "The server advertises no staging capability for this snapshot: Platform v2 defines neither a staging confirmation digest nor a receipt correlation, and hunk-level granularity is not representable in it. Staged, unstaged, untracked and conflict state stay visible, with no staging control."
fleet.review.staging_withheld_no_custody_lane = "Durable custody is unavailable in this process: no staging control is offered."
fleet.review.preview_text = "Sanitized text preview"
fleet.review.preview_image = "Image %{media} · %{width}×%{height} px · %{bytes} bytes"
Expand Down
10 changes: 8 additions & 2 deletions crates/shelldeck-core/locales/fr.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1217,7 +1217,12 @@ fleet.review.note_delete = "Supprimer"
fleet.review.note_stale = "Instantané dépassé"
fleet.review.note_failed = "La note ancrée n’a pas pu être enregistrée."
fleet.review.save_note = "Enregistrer la note"
fleet.review.batch_blocked = "%{count} note(s) sélectionnée(s) et conservées. L’envoi groupé vers la session autorisée reste indisponible : le serveur n’annonce aucune capacité pour cette action."
fleet.review.notes_selected = "%{count} note(s) sélectionnée(s) et conservées. Une note est un brouillon local : préparez-la en commentaire pour qu’elle devienne livrable à la session autorisée."
fleet.review.prepare_batch_send = "Envoyer %{count} commentaire(s) à la session"
fleet.review.delivery_withheld_title = "Envoi groupé indisponible"
fleet.review.delivery_withheld_no_server_capability = "Aucune réponse de capacité n’est attribuée à ce projet, cet espace et cette révision d’instantané : rien n’a été annoncé, donc aucune commande d’envoi n’est proposée."
fleet.review.delivery_withheld_no_deliverable_comment = "Le serveur n’annonce aucun commentaire livrable pour cet instantané : aucune session autorisée n’y est reliée, ou aucun commentaire n’est dans un état envoyable. L’annonce est relue à chaque rafraîchissement, y compris après un envoi."
fleet.review.delivery_withheld_no_custody_lane = "La garde durable est indisponible dans ce processus : aucune commande d’envoi groupé n’est proposée."
fleet.review.attention_title = "Chronologie d’attention"
fleet.review.confirm_comment = "Dans le projet %{project}, espace %{workspace} : ajouter « %{body} » sur %{file} · %{hunk} · %{side}:%{line}, depuis l’instantané exact %{revision}."
fleet.review.confirm_approval = "Dans le projet %{project}, espace %{workspace} : approuver la rév. de revue %{review_revision}, depuis l’instantané exact %{revision}."
Expand All @@ -1233,6 +1238,7 @@ fleet.review.pending_detail = "Action envoyée une seule fois ; les tentatives s
fleet.review.invalid_preview = "L’action ne correspond plus exactement à la revue active."
fleet.review.never_dispatched = "L’aperçu préparé avant le redémarrage n’a jamais été envoyé."
fleet.review.capability_stale = "La capacité de relance a changé ; rechargez puis confirmez un nouvel aperçu."
fleet.review.delivery_capability_stale = "L’annonce de livraison a changé ; rechargez puis préparez une nouvelle sélection."
fleet.review.custody_failed = "La garde durable a refusé l’envoi ; aucun appel fournisseur n’a commencé."
fleet.review.receipt_actor = "%{detail} · acteur %{actor}"
fleet.review.receipt_actor_short = "acteur %{actor}"
Expand All @@ -1244,7 +1250,7 @@ fleet.review.lane_partial = "partiellement indexé"
fleet.review.staging_proposed = "%{action} · proposition %{id}"
fleet.review.staging_blocked = "%{action} · bloqué · proposition %{id}"
fleet.review.staging_withheld_title = "Indexation en lecture seule"
fleet.review.staging_withheld_no_server_capability = "Le serveur n’annonce aucune capacité d’indexation pour cet instantané : Platform v2 ne publie que la relance de contrôle. L’état indexé, non indexé, non suivi et en conflit reste affiché, sans commande d’indexation."
fleet.review.staging_withheld_no_server_capability = "Le serveur n’annonce aucune capacité d’indexation pour cet instantané : Platform v2 ne définit ni digest de confirmation ni corrélation de reçu pour l’indexation, et la granularité au niveau du bloc n’y est pas représentable. L’état indexé, non indexé, non suivi et en conflit reste affiché, sans commande d’indexation."
fleet.review.staging_withheld_no_custody_lane = "La garde durable est indisponible dans ce processus : aucune commande d’indexation n’est proposée."
fleet.review.preview_text = "Aperçu texte assaini"
fleet.review.preview_image = "Image %{media} · %{width}×%{height} px · %{bytes} octets"
Expand Down
6 changes: 4 additions & 2 deletions crates/shelldeck-core/src/config/platform.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1684,7 +1684,7 @@ mod tests {
use automonique_protocol::platform_v2_transport::{
PlatformNegotiationResponse, PlatformV2Refusal, PlatformV2Request, PlatformV2Response,
ReviewCapabilities, ReviewCheckRerunCapability, ReviewConfirmationDigest,
ReviewReceiptCorrelationDigest,
ReviewPullRequestCapabilities, ReviewReceiptCorrelationDigest,
};

let snapshot = decode_review_snapshot(include_bytes!(
Expand Down Expand Up @@ -1716,6 +1716,8 @@ mod tests {
correlation.clone(),
)
.unwrap()],
Vec::new(),
ReviewPullRequestCapabilities::default(),
)
.unwrap();
let negotiated = || {
Expand All @@ -1738,7 +1740,7 @@ mod tests {
let mut capability_client = PlatformV2Client::new_testing(capability_transport);
assert_eq!(
load_review_capabilities(&mut capability_client, &target).unwrap(),
PlatformReviewCapabilitiesLoad::Available(capabilities.clone())
PlatformReviewCapabilitiesLoad::Available(Box::new(capabilities.clone()))
);
assert!(matches!(
capability_client.transport().requests()[0].request(),
Expand Down
Loading
Loading