Repository navigation
Conversation
toprameen
marked this pull request as ready for review
November 2, 2026 19:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File.read_atstill uses the whole regular-file size for its initial JS buffer hint, even when its offset leaves only a small tail. Reading the final five bytes of a 1 GiB sparse file with a 1 GiB cap therefore allocates a 1 GiB buffer.The reader now subtracts the known offset from the size hint while retaining the 64 KiB floor and existing growth loop. The same read starts with 64 KiB and returns the same bytes. Sequential and line reads retain their existing sizing rules.
The extended cap fixture tests repeated positioned tail reads. On local macOS, the unchanged source CLI, compiled CLI and emitted Bun/Node exceed its five-second alarm; the patch passes all four, and native C passes before and after. Neighboring file fixtures and offset/EOF/cursor checks pass. Repository gate: 54/54; strict TypeScript reports the same seven baseline diagnostics.