Conditionally inner join user table if creator is present in query#32
Open
Devorein wants to merge 1 commit intobenawad:masterfrom
Open
Conditionally inner join user table if creator is present in query#32Devorein wants to merge 1 commit intobenawad:masterfrom
Devorein wants to merge 1 commit intobenawad:masterfrom
Conversation
AaronMcCloskey
suggested changes
Oct 8, 2021
| let parent = info.operation.selectionSet; | ||
| for (let index = 0; index < fields.length; index++) { | ||
| const field = fields[index]; | ||
| const selectionNode = parent.selections.find(selection=>(selection as any).name.value === field) ?? false; |
There was a problem hiding this comment.
This will not work with using Fragments as the name.value will resolve as the Fragment name, i.e PostSnippet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses issue #29 to utilize limit instead of
takeand conditionally inner joins the user table if the query contains thecreatorfield, using an util method.