💍 Rings! 💍

[ben-cassese]

A from-scratch new attempt at transits of planets with opaque rings. Creates a new RingedSystem class built on OblateSystem. Still handles arbitrary order polynomial limb darkening, arbitrary 3D geometry of the planet+rings. Takes ~10s of ms per likelihood call now compared to ~3ms for the vanilla oblate system, but at least it now correctly handles all of the possible intersections. Also fixes a bug the incorrectly handled extremely thin on-sky ellipses with 4 intersection points with the star instead of 2.

[codecov]

Codecov Report

❌ Patch coverage is 96.70659% with 11 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
squishyplanet/engine/rings.py	91.66%	4 Missing ⚠️
squishyplanet/ringed_system.py	96.11%	4 Missing ⚠️
squishyplanet/engine/parametric_ellipse.py	86.36%	3 Missing ⚠️

Files with missing lines	Coverage Δ
squishyplanet/__init__.py	100.00% <100.00%> (ø)
...yplanet/engine/polynomial_limb_darkened_transit.py	99.56% <100.00%> (-0.04%)	⬇️
squishyplanet/engine/ringed_transit.py	100.00% <100.00%> (ø)
squishyplanet/engine/parametric_ellipse.py	94.54% <86.36%> (-5.46%)	⬇️
squishyplanet/engine/rings.py	91.66% <91.66%> (ø)
squishyplanet/ringed_system.py	96.11% <96.11%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.