Skip to content

fix(harness): complete onRound for all exit paths + normalize state #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
belarusian merged 1 commit into from
Jun 18, 2026
Merged

fix(harness): complete onRound for all exit paths + normalize state #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/agent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -378,7 +378,7 @@ function runAgentStream(input: AgentLoopInput): Stream.Stream<LLMEvent, Error> {
if (!hasToolCalls) {
const finalState: AgentLoopState = {
round: round + 1,
messageCount: history.length + 2,
messageCount: history.length,
toolCallCount,
lastFinishReason: finishReason,
hasToolCalls: false,
Expand Down Expand Up @@ -406,7 +406,7 @@ function runAgentStream(input: AgentLoopInput): Stream.Stream<LLMEvent, Error> {
// Model returned tool-calls finish reason but no valid tool calls — fire callback with stuck state
const stuckState: AgentLoopState = {
round: round + 1,
messageCount: history.length + 2,
messageCount: history.length,
toolCallCount,
lastFinishReason: finishReason,
hasToolCalls: false,
Expand Down Expand Up @@ -815,7 +815,16 @@ export const makeAgentLoop = Layer.effect(
}
}

// Max steps reached
// Max steps reached
const stateMax: AgentLoopState = {
round,
messageCount: history.length,
toolCallCount,
lastFinishReason,
hasToolCalls: false,
lastText,
}
if (input.onRound) { try { input.onRound(stateMax); } catch {} }
const response = buildResponse(lastEvents, accumulatedUsage)
return {
response,
Expand Down
Loading