Skip to content

docs+script: harden deploy-new-server.sh and document it - #3

Merged
bejranonda merged 1 commit into
mainfrom
deploy-script-docs
May 8, 2026
Merged

bejranonda merged 1 commit into
mainfrom
deploy-script-docs

Conversation

@bejranonda

Copy link
Copy Markdown
Owner

Summary

  • Tighten Caddyfile sed in scripts/deploy-new-server.sh (literal placeholder match, no SC2015 warning)
  • Document the wrapper across README, setup-server (Step 0), knowledge, known-issues, guidelines, approach, and CLAUDE.md
  • Explain why this script lives outside the one-script lifecycle rule

Test plan

  • `bash -n scripts/deploy-new-server.sh` — syntax ok
  • `shellcheck scripts/deploy-new-server.sh` — clean
  • Caddyfile sed verified against `deploy/caddy/Caddyfile`
  • Run on a fresh Ubuntu 24.04 box (manual)

🤖 Generated with Claude Code

- Tighten Caddyfile sed substitution: use literal `{$CKP_DOMAIN:example.com}`
  match instead of a fragile regex chain. Quiets shellcheck SC2015.
- README: link the wrapper from the production-deploy section.
- docs/setup-server.md: add Step 0 fast-path with curl-pipe usage.
- docs/knowledge.md: surface the wrapper in the lifecycle table.
- docs/known-issues.md: mark the previous multi-step bootstrap as resolved.
- docs/guidelines.md + docs/approach.md: explain why this script lives
  outside the one-script lifecycle rule (install-only glue, runs above
  the target).
- CLAUDE.md: add a "deploy to a new server" section.
@bejranonda
bejranonda merged commit 8b5a774 into main May 8, 2026
@bejranonda
bejranonda deleted the deploy-script-docs branch May 8, 2026 18:00
@coderabbitai

coderabbitai Bot commented May 8, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@bejranonda has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 29 minutes and 53 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: d99cec4b-a5b0-4d6b-b93a-44032ece340d

📥 Commits

Reviewing files that changed from the base of the PR and between ddc6f44 and b2d6be3.

📒 Files selected for processing (8)
  • CLAUDE.md
  • README.md
  • docs/approach.md
  • docs/guidelines.md
  • docs/knowledge.md
  • docs/known-issues.md
  • docs/setup-server.md
  • scripts/deploy-new-server.sh
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch deploy-script-docs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants