Feat/mini game reward#49
Open
viettu-bic wants to merge 18 commits into
Open
Conversation
…ic-smart-contract-v2 into feat/mini-game-reward
(+) merkle proof root multi leafs
…ic-smart-contract-v2 into feat/mini-game-reward
… into feat/mini-game-reward
… proof calculation in BicEdition
ntnam-bic
reviewed
Sep 10, 2025
| merkleRoots[_merkleRoot].endTime = _endTime; | ||
| emit MerkleRootUpdated(_merkleRoot, _endTime); | ||
| } else { | ||
| merkleRoots[_merkleRoot] = MerkleRootInfo({ |
Contributor
There was a problem hiding this comment.
nên tách quyền update chỉ cho owner với thêm cơ chế để owner có thể paused active root trong emergency case có error trong việc build merkle và đã public. Property exist có thể thay cho paused và check exist nếu merkle root có length bytes
ntnam-bic
reviewed
Sep 15, 2025
Contributor
There was a problem hiding this comment.
access storage trong lib access còn "1CP.access.storage"
Contributor
There was a problem hiding this comment.
cần căn nhắc đặt trên các selectors do selector sẽ aggregate lại trong diamond
Contributor
Author
There was a problem hiding this comment.
T không hiểu lắm đoạn này, nó thiên về config ở script deploy hay gì vậy
…uding addition, update, and pause functionality. Update LibAccess storage key for consistency. Add corresponding error handling and tests for new functionalities.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.