Skip to content

Add TimeInput support for iOS.#3536

Merged
freakboy3742 merged 11 commits intobeeware:mainfrom
johnzhou721:iostimeinput
Jun 11, 2025
Merged

Add TimeInput support for iOS.#3536
freakboy3742 merged 11 commits intobeeware:mainfrom
johnzhou721:iostimeinput

Conversation

@johnzhou721
Copy link
Copy Markdown
Contributor

@johnzhou721 johnzhou721 commented Jun 6, 2025 •
edited by freakboy3742
Loading

Refs #1939.

PR Checklist:

  • All new features have been tested
  • All new features have been documented
  • I have read the CONTRIBUTING.md file
  • I will abide by the code of conduct

johnzhou721
johnzhou721 commented Jun 6, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@johnzhou721 johnzhou721 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some notes. Let me know if you want some of those as comments in the code, but I feel they're too lengthy to be.

Comment thread changes/3483.feature.rst
Comment thread docs/reference/api/widgets/timeinput.rst Outdated
Comment thread iOS/src/toga_iOS/widgets/dateinput.py
Comment thread iOS/src/toga_iOS/widgets/timeinput.py Outdated
Comment thread iOS/tests_backend/widgets/dateinput.py
Comment thread iOS/tests_backend/widgets/timeinput.py Outdated
@johnzhou721 johnzhou721 mentioned this pull request Jun 6, 2025
Open
@johnzhou721 johnzhou721 marked this pull request as draft June 6, 2025 21:15
@johnzhou721
Copy link
Copy Markdown
Contributor Author

johnzhou721 commented Jun 6, 2025

Marking as draft since I just realized I had beeware/Python-Apple-support#280 and I feel like I should stop overwheling reviewers.

@johnzhou721
Copy link
Copy Markdown
Contributor Author

johnzhou721 commented Jun 6, 2025

Nevermind... There's more people on the core team and I realized that if some have time I shouldn't be blocking this because of a totally unrelated thing...

@johnzhou721 johnzhou721 marked this pull request as ready for review June 6, 2025 23:24
freakboy3742
freakboy3742 requested changes Jun 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broadly looks on the right track; a few notes inline, mostly about seconds handling.

Comment thread docs/reference/api/widgets/timeinput.rst Outdated
Comment thread iOS/tests_backend/widgets/dateinput.py
Comment thread iOS/tests_backend/widgets/dateinput.py
Comment thread iOS/src/toga_iOS/widgets/timeinput.py Outdated
Comment thread iOS/src/toga_iOS/widgets/timeinput.py Outdated
Comment thread iOS/tests_backend/widgets/timeinput.py Outdated
@freakboy3742
Copy link
Copy Markdown
Member

freakboy3742 commented Jun 9, 2025

Marking as draft since I just realized I had beeware/Python-Apple-support#280 and I feel like I should stop overwheling reviewers.
...
Nevermind... There's more people on the core team and I realized that if some have time I shouldn't be blocking this because of a totally unrelated thing...

Sure - but we don't have unlimited time. The more reviews you ask for, the bigger the backlog gets; and small PRs will always take priority over larger ones because large PRs take longer to review.

@johnzhou721 @freakboy3742
Update docs/reference/api/widgets/timeinput.rst
b10fd56 
Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
johnzhou721
johnzhou721 commented Jun 9, 2025
View reviewed changes
Comment thread iOS/src/toga_iOS/widgets/timeinput.py Outdated
johnzhou721
johnzhou721 commented Jun 9, 2025
View reviewed changes
Comment thread iOS/src/toga_iOS/widgets/timeinput.py
johnzhou721
johnzhou721 commented Jun 9, 2025
View reviewed changes
Comment thread iOS/src/toga_iOS/widgets/timeinput.py Outdated
@johnzhou721 johnzhou721 requested a review from freakboy3742 June 10, 2025 22:01
freakboy3742
freakboy3742 approved these changes Jun 10, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@freakboy3742 freakboy3742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One very niche edge case correction, but otherwise this looks good - thanks for the PR.

Comment thread iOS/src/toga_iOS/widgets/timeinput.py Outdated
freakboy3742
freakboy3742 reviewed Jun 10, 2025
View reviewed changes
Comment thread android/src/toga_android/widgets/timeinput.py Outdated
freakboy3742
freakboy3742 reviewed Jun 10, 2025
View reviewed changes
Comment thread android/src/toga_android/widgets/timeinput.py Outdated
@johnzhou721
Copy link
Copy Markdown
Contributor Author

johnzhou721 commented Jun 11, 2025

Thank you! Sorry for the units frenzy.

@freakboy3742 freakboy3742 merged commit 658d4e0 into beeware:main Jun 11, 2025
102 of 103 checks passed
freakboy3742 pushed a commit to freakboy3742/toga that referenced this pull request Jun 14, 2025
@johnzhou721 @freakboy3742
Add TimeInput support for iOS. (beeware#3536)
df5d83b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@johnzhou721 @freakboy3742