Repository navigation
connector: keep the E2EE reconnect prompt after a restart - #298
Merged
Merged
Conversation
A login flagged for a full E2EE reconnect went back to CONNECTED on the next restart, and later decrypt failures never resent the prompt because markMissingE2EEKey returned early when the flag was already saved. Send line-e2ee-key-missing at connect while the flag is set, and always send it when a missing key is first seen by this client.
Contributor
Author
|
No issues found.
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
highesttt
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What the logs show. Over the last 24 h, 11 production logins logged
DecryptMessageV2 failed on retrywithmissing my private key(409 lines; 100-300 a day for the past week). Each one reaches the user as "[Unable to decrypt LINE message.]". 10 of those 11 logins currently report CONNECTED. Two of them did getline-e2ee-key-missingright after a re-login that kept stale keys, but the next restart flipped them back to CONNECTED. One login has been failing for at least 5 days and never showed the prompt.Cause.
ForceFullE2EELoginis saved in metadata, butmissingE2EEKeyMarkedonly lives in memory. After a restart,Connectsends CONNECTED. Then on the next missing-key failure,markMissingE2EEKeysees the flag already saved (needsSave == false) and returns before it sends the bridge state.Change.
sendConnectedStateIfCurrentsendsline-e2ee-key-missinginstead of CONNECTED while the flag is set, and marks the client so SSE reconnects don't overwrite it.markMissingE2EEKeynow always sends the state the first time this client sees a missing key. It only skips the save.Built with
go build ./...andgo vet ./pkg/connector/.go test -short ./pkg/connector/passes.Tag
@indentto continue the conversation here.