[indent]

Production logs over 24 h: search_users p90 is 116 s and p99 819 s. Six accounts had searches over 10 s; for one, the median search took 182 s and the slowest 875 s. That account also logged about 6.7k Failed to update ghost in database after updating info: context canceled errors and 4.6k avatar timeouts in 35 minutes, all from search requests the client had already abandoned.

Cause: SearchUsers already gets every contact from the batched GetContactsV2, but it then looked each match up again through GetUserInfo, one network call per contact with a BuddyService fallback. It returned every match, and it kept going after the request context was canceled. The provisioning API then syncs each result's ghost, one after another. GetAvatar ignored the context, so every avatar download kept running for up to 10 s after cancellation. It also uploaded non-200 bodies as avatars.

Change:

• Cache the contacts from the batch lookup.
• Cap name matches at 20, the limit the user-ID path already used.
• Stop between batches once the context is done, in both search and the contact list.
• Make GetAvatar use the request context and reject non-200 responses.

Tag @indent to continue the conversation here.

[indent]

Issues

No issues found.

CI Checks

All CI checks passed on 60aeabc.

Review agents

Select any unchecked box below to run or rerun that agent.

Passed (1)

• Indent Review Agent · No issues found in the contact search changes.

Full results

Indent Review Agent

• Summary: No issues found in the contact search changes.
• Last ran on commit: 60aeabcd
• Latest result

  {
    "summary": "No issues found in the contact search changes.",
    "findings": []
  }