Repository navigation
handlers: upload link preview images instead of sending LINE CDN URLs - #293
Merged
Merged
Conversation
Contributor
|
All clear! No issues remaining. 🎉 1 issue already resolved
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
…quire an image type
highesttt
approved these changes
Oct 28, 2026
highesttt
left a comment
Collaborator
There was a problem hiding this comment.
Don't know how I missed that one
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link previews on incoming LINE messages show no image.
ConvertTextputs LINE's CDN URL straight intoog:image, but MSC4095 previews need an mxc there, so clients reject it. Android logs this for every preview and retries it over and over:This change downloads the preview image (the pagepoker CDN is public, no auth) and uploads it with
intent.UploadMediainto the portal, the same way the other bridges handle preview thumbnails. In encrypted rooms that fillsbeeper:image:encryption. If the download fails, the preview goes out without an image instead of with a broken one.ConvertTextnow takes ctx, portal and intent, so its three callers pass them through.og:imagehttps://pagepoker.line-scdn.net/...mxc://...(orbeeper:image:encryption)Tag
@indentto continue the conversation here.