Repository navigation
stickers: bridge LINE stickers as m.sticker at LINE's display size - #273
Open
iFixRobots wants to merge 1 commit into
Open
iFixRobots wants to merge 1 commit into
iFixRobots wants to merge 1 commit into
Conversation
Stickers were sent as m.image with no dimensions, so clients fell back to their default image size (Desktop renders them 400 px tall). Send them as m.sticker with width/height set to LINE's PC/@1x size (2/3 of the Android asset we download). Advertise sticker support and send Matrix stickers to LINE as images so forwarding a bridged sticker keeps working.
|
1 potential issue found:
↑ Select any checkbox above to have Indent auto-fix the issue
All CI checks passed on
Select any unchecked box below to run or rerun that agent. Full resultsIndent Review Agent
|
highesttt
approved these changes
Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LINE stickers were bridged as
m.imagewith noinfo.w/info.h, so clients used their default image size. Beeper Desktop renders an image without dimensions 400 px tall, so a sticker LINE shows at 185×150 shows up about 2.7× larger.This sends stickers as
m.stickerwith dimensions, the same way the WhatsApp (190 px) and Signal (200 px) bridges do. The size is LINE's own display size. The CDN serves each sticker as an Android asset at 0.75× the original and as PC and iPhone @1x assets at 0.5×, so the display size is 2/3 of the Android file we already download. For example, sticker 52002734 is 278×225 on Android and 185×150 on PC. The other stickers I checked also matched to the pixel.Since bridged stickers are now
m.sticker, the room features advertise sticker support, and Matrix stickers go out to LINE as images. That keeps forwarding a bridged sticker working, because iOS checksfile[m.sticker]before allowing a forward. The capabilities ID is bumped.go build,go vetand the existing connector tests pass.Tag
@indentto continue the conversation here.