Repository navigation
docs(f1): nothing may ride along in the desktop bundle, and something must read it - #114
Merged
Merged
Conversation
… must read it Every published desktop release from v1.0.1-beta to v1.3.0 carried a vendored package's README with a complete PEM private key in its usage example, and a second package's linting configuration. Neither is a secret of this product's and neither is autoloaded — what earns them a requirement is that no job in the release pipeline ever read a desktop artefact, so the next file to ride along would have been equally invisible. F8-R6 and F8-R7 already state this for a mobile bundle. F1-R19 states it for the desktop one, and F1-R20 states the half the mobile side learned the hard way: a read that cannot tell "found no bundle" from "found a clean bundle" is a check that can sit broken indefinitely. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Wessel Verheij <info@nightworks.io>
lessevv
enabled auto-merge (squash)
September 13, 2026 17:53
github-actions
Bot
added
documentation
|
github-actions
Bot
added
awaiting-maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
Two new acceptance criteria on F1 — Desktop shell and packaging, and the narrative section that earns them.
Why
F8-R6andF8-R7already state this for a mobile bundle, and the mobile side hasmobile:inspect-bundlerunning on every release. The desktop side had neither the requirement nor the read.Measured, not inferred. Every published macOS artefact was downloaded from the release page and opened:
vendor/firebase/php-jwt/README.md— a completeBEGIN RSA PRIVATE KEYblock (lines 115–141 of that file), plusvendor/brick/money/tools/ecs/Neither is a secret of this product's: both are fixtures their authors publish openly, and neither is reachable from any autoloader. What earns a requirement is that nothing in the release pipeline read a desktop artefact at all —
release.ymlhas no desktop artefact read of any kind — so the next file to ride along would have been equally invisible.F1-R20 exists separately because the mobile side learned that half the hard way: a check that cannot tell "found no bundle" from "found a clean bundle" is one that can sit broken indefinitely and look green.
Checks
python3 scripts/integrity.py,manifest_check.py,typos,lycheeandmarkdownlint-cli2all clean locally.The implementation PR in
beatraxcitesF1-R19.