Skip to content

Index local oci image to remote #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
luke-lombardi merged 1 commit into from
Nov 4, 2025
Merged

Index local oci image to remote #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions pkg/clip/oci_indexer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,20 +109,25 @@ func (ca *ClipArchiver) IndexOCIImage(ctx context.Context, opts IndexOCIImageOpt
// Build remote options with authentication
remoteOpts := []remote.Option{remote.WithContext(ctx)}

// IMPORTANT: Get credentials for the SOURCE registry (where we're fetching from),
// not the storage reference (which is just stored in metadata)
fetchRegistryURL := ref.Context().RegistryStr()
fetchRepository := ref.Context().RepositoryStr()

// Try to get credentials from provider
authConfig, err := credProvider.GetCredentials(ctx, registryURL, repository)
authConfig, err := credProvider.GetCredentials(ctx, fetchRegistryURL, fetchRepository)
if err != nil && err != common.ErrNoCredentials {
log.Warn().
Err(err).
Str("registry", registryURL).
Str("registry", fetchRegistryURL).
Str("provider", credProvider.Name()).
Msg("Failed to get credentials from provider, falling back to keychain")
}

if authConfig != nil {
// Use provided credentials
log.Debug().
Str("registry", registryURL).
Str("registry", fetchRegistryURL).
Str("provider", credProvider.Name()).
Msg("Using credentials from provider")
// Convert AuthConfig to proper authenticator (handles all auth types: username/password, tokens, etc.)
Expand All @@ -131,7 +136,7 @@ func (ca *ClipArchiver) IndexOCIImage(ctx context.Context, opts IndexOCIImageOpt
} else {
// Fall back to default keychain for anonymous or keychain-based auth
log.Debug().
Str("registry", registryURL).
Str("registry", fetchRegistryURL).
Msg("No credentials from provider, using default keychain")
remoteOpts = append(remoteOpts, remote.WithAuthFromKeychain(authn.DefaultKeychain))
}
Expand Down