Skip to content
This repository was archived by the owner on Dec 27, 2022. It is now read-only.

update package to include babel-polyfill as dependency#15

Open
e-e-e wants to merge 1 commit intobeakerbrowser:masterfrom
e-e-e:patch-1
Open

update package to include babel-polyfill as dependency#15
e-e-e wants to merge 1 commit intobeakerbrowser:masterfrom
e-e-e:patch-1

Conversation

@e-e-e
Copy link
Copy Markdown
Contributor

@e-e-e e-e-e commented Jul 6, 2017

I just realised that the es5 compatibility that I added a few months ago is broken for anyone who does not have babel-polyfill in their package.
This is a simple fix to remedy that problem. Sorry for the silly mistake.

@pfrazee
Copy link
Copy Markdown
Member

pfrazee commented Jul 6, 2017

I appreciate the PR! But I'm not super enthusiastic about including those deps in my projects, since I don't use es5. Is there any way we can do this differently?

@e-e-e
Copy link
Copy Markdown
Contributor Author

e-e-e commented Jul 6, 2017

I completely understand. I was kind of surprised that babel expects such dependency after already transpiling the code - seems poor practice. I did a bit of research on how to avoid it and could not find anything obvious, but let me have another look. Perhaps now node 6 is LTS we could just increase es5 to es6 which I don’t think would require the polyfill for promises, etc.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants