This repository was archived by the owner on Dec 27, 2022. It is now read-only.
update package to include babel-polyfill as dependency#15
Open
e-e-e wants to merge 1 commit intobeakerbrowser:masterfrom
Open
update package to include babel-polyfill as dependency#15e-e-e wants to merge 1 commit intobeakerbrowser:masterfrom
e-e-e wants to merge 1 commit intobeakerbrowser:masterfrom
Conversation
Member
|
I appreciate the PR! But I'm not super enthusiastic about including those deps in my projects, since I don't use es5. Is there any way we can do this differently? |
Contributor
Author
|
I completely understand. I was kind of surprised that babel expects such dependency after already transpiling the code - seems poor practice. I did a bit of research on how to avoid it and could not find anything obvious, but let me have another look. Perhaps now node 6 is LTS we could just increase es5 to es6 which I don’t think would require the polyfill for promises, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just realised that the es5 compatibility that I added a few months ago is broken for anyone who does not have babel-polyfill in their package.
This is a simple fix to remedy that problem. Sorry for the silly mistake.