Better support for hash_including matching - #115
Open
bdurand wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lumberjack::LogEntryMatcherno longer ignores anattributesfilter that is not a hash. Passing a matcher like RSpec'shash_includingas the entire filter silently matched every entry; it is now applied to the entry's attributes hash with===.Lumberjack::LogEntryMatchernow exposes log entry attributes to matchers with indifferent key access, so matchers that do their own key lookups (i.e. RSpec'shash_including) can use either string or symbol attribute names.