[CHORE] - fix core web ts errors#3885
Merged
matbusby-fw merged 2 commits intodevelopfrom Apr 10, 2026
Merged
Conversation
matbusby-fw
changed the title
|
|
|
simensma-fresh
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR focuses on resolving recurring TypeScript errors and stabilizing snapshot tests that were inconsistently updating in different environments.
1. MineSpace Snapshot Stabilization
Snapshots in the MineSpace-web service were frequently updating locally due to environment-specific locale and timezone differences (specifically regarding date formatting).
minespace-web/src/setupTests.jsby forcingUTCas the default timezone for both the Node process andmoment.Date.prototype.toLocaleString()calls with explicitmoment().format()inMinespaceAccessRequest.tsx. This ensures that date strings are rendered consistently regardless of the local developer locale.2. Core-web & Common TypeScript/Logic Cleanup
Resolved several TypeScript errors and React best-practice violations in
core-weband@mds/commonservices.EditTsfAppointmentForm.tsxto use.unwrap()on dispatched actions for more robust asynchronous result handling.IPartyApptinterface with missingstatusandmine_party_acknowledgement_statusfields.EngineerOfRecord.tsxandEditPartyModal.tsxby adding appropriate type mapping forgetPartiesandgetPartyRelationships.PartySelectField.tsxto useReact.ReactNodefor labels to improve component compatibility.InactiveContact.tsxby moving a<Redirect />component out of auseEffecthook and into the main render block.