NumberField: remove hardcoded minValue#773
Open
mkernohanbc wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates NumberField to apply a default minValue of 0 via parameter destructuring (instead of an inline JSX literal), ensuring the default is preserved even when callers pass minValue={undefined}.
Changes:
- Destructure
minValuewith a default of0in theNumberFieldcomponent signature. - Pass the destructured
minValuethrough toReactAriaNumberFieldinstead of usingminValue={0}.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mkernohanbc
added
the
react-components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change corrects an error in how
minValueis handled in NumberField, that surfaced during some testing work.NumberField previously had its
minValuehardcoded to0— which is the desired default behaviour, but would also potentially cause issues if someone wanted to set a differentminValue.This change destructures
minValuein order to set the desired default, without hard-coding it.