Add Code Connect mappings for icons#761
Open
mkernohanbc wants to merge 5 commits into
Open
Conversation
mkernohanbc
added
the
react-components
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Figma Code Connect mapping files for a set of icon React components so they can be referenced from the Design System Figma library (per #670) without changing runtime component code.
Changes:
- Introduces new
*.figma.tsCode Connect mapping files alongside existing icon components. - Each mapping currently provides basic import + example usage wiring for the corresponding icon.
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-components/src/components/Icons/SvgPlusIcon/SvgPlusIcon.figma.ts | Code Connect mapping for SvgPlusIcon. |
| packages/react-components/src/components/Icons/SvgMinusIcon/SvgMinusIcon.figma.ts | Code Connect mapping for SvgMinusIcon. |
| packages/react-components/src/components/Icons/SvgCheckIcon/SvgCheckIcon.figma.ts | Code Connect mapping for SvgCheckIcon. |
| packages/react-components/src/components/Icons/SvgCheckCircleIcon/SvgCheckCircleIcon.figma.ts | Code Connect mapping for SvgCheckCircleIcon. |
| packages/react-components/src/components/Icons/SvgInfoIcon/SvgInfoIcon.figma.ts | Code Connect mapping for SvgInfoIcon. |
| packages/react-components/src/components/Icons/SvgExclamationIcon/SvgExclamationIcon.figma.ts | Code Connect mapping for SvgExclamationIcon. |
| packages/react-components/src/components/Icons/SvgExclamationCircleIcon/SvgExclamationCircleIcon.figma.ts | Code Connect mapping for SvgExclamationCircleIcon. |
| packages/react-components/src/components/Icons/SvgCloseIcon/SvgCloseIcon.figma.ts | Code Connect mapping for SvgCloseIcon. |
| packages/react-components/src/components/Icons/SvgChevronUpIcon/SvgChevronUpIcon.figma.ts | Code Connect mapping for SvgChevronUpIcon. |
| packages/react-components/src/components/Icons/SvgChevronRightIcon/SvgChevronRightIcon.figma.ts | Code Connect mapping for SvgChevronRightIcon. |
| packages/react-components/src/components/Icons/SvgChevronLeftIcon/SvgChevronLeftIcon.figma.ts | Code Connect mapping for SvgChevronLeftIcon. |
| packages/react-components/src/components/Icons/SvgChevronDownIcon/SvgChevronDownIcon.figma.ts | Code Connect mapping for SvgChevronDownIcon. |
| packages/react-components/src/components/Icons/SvgCalendarIcon/SvgCalendarIcon.figma.ts | Code Connect mapping for SvgCalendarIcon. |
| packages/react-components/src/components/Icons/SvgPlaceholderIcon/SvgPlaceholderIcon.figma.ts | Code Connect mapping for SvgPlaceholderIcon. |
| packages/react-components/src/components/Icons/SvgBcOutlineIcon/SvgBcOutlineIcon.figma.ts | Code Connect mapping for SvgBcOutlineIcon. |
| packages/react-components/src/components/Icons/SvgBcLogo/SvgBcLogo.figma.ts | Code Connect mapping for SvgBcLogo. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #670. It adds Code Connect mapping files for icons that currently exist as components in both Figma and React.
There are a small number of React components that aren't used in Figma, and a larger number of icon components in Figma that aren't currently represented in React.
This change doesn't touch existing code — it simply adds new
*.figma.tsfiles alongside each component. Currently, the mappings are basic (i.e. they just point to the right component to import.) The icon components in Figma don't have much in the way of their own controls or properties, so this change is independent of #760.