Menu: fix TypeScript error#759
Open
mkernohanbc wants to merge 1 commit into
Open
Conversation
mkernohanbc
added
react-components
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Menu component’s TypeScript types to resolve an incompatibility stemming from inconsistent items typing between MenuSectionProps and MenuProps, aligning MenuProps.items to use MenuItemProps[].
Changes:
- Remove the generic type parameter from
MenuPropsand theMenucomponent signature. - Type
MenuPropsasReactAriaMenuProps<MenuItemProps>anditems?: MenuItemProps[]to matchMenuSectionProps.items.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+28
to
+32
| export interface MenuProps extends ReactAriaMenuProps<MenuItemProps> { | ||
| /* Set size of menu items (does not affect the MenuTrigger element) */ | ||
| itemSize?: "small" | "medium"; | ||
| /* Use for a simple list menu */ | ||
| items?: T[]; | ||
| items?: MenuItemProps[]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a TypeScript error in the Menu component. Previously, there was an inconsistency in how the
itemsprop (used to pass an array of menu items) was typed in theMenuSectionPropsandMenuPropsinterfaces. InMenuPropsit was typed asitems?: T[], which caused an incompatibility error with theonActioncallback.With this change,
itemsis now typed consistently asitems: MenuItemProps[]in both contexts. This resolves the error, and is consistent with how we've approached this same functionality in Select.