fix(api): incorrect new expiration date when renewing expired registration

[JazzarKarim]

Issue:

• Bug: Incorrect new expiration date when renewing an expired registration entity#32519

Description of changes:
Basically,

if (registrationDaysLeft > 0 days) {
   expiryDate = expiryDate + 365 days;
} else {
   expiryDate = TODAY + 365 days;
}

Scenario 1:

Scenario 2:

Some more testing:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the BC Registry and Digital Services BSD 3-Clause License

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud