#5501 - FT/PT Assessment Disabled Spouse Path #5690
+463
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Mistakenly updated the wrong year application forms. Fixed it.
sh16011993
changed the title
sh16011993
added
Form.io
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements the spouse dependant path for both full-time and part-time assessments in the 2026-2027 program year. The changes enable students to identify whether their spouse/common-law partner is considered a dependant, and ensures family size calculations correctly account for dependant vs. independent spouses.
Changes:
- Added spouse dependant questions to 2026-2027 FT and PT application forms with conditional visibility
- Updated BPMN workflows to calculate family size by excluding spouse dependants from the count (spouse already counted in married status)
- Added comprehensive e2e tests covering dependant spouse, independent spouse, and non-spouse dependant scenarios
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| sources/packages/forms/src/form-definitions/sfaa2026-27-pt.json | Added spouse dependant question and relationship field to part-time form |
| sources/packages/forms/src/form-definitions/sfaa2026-27-ft.json | Added spouse dependant question and relationship field to full-time form |
| sources/packages/backend/workflow/test/models/assessment.model.ts | Added dependantRelationship field to StudentDependent interface |
| sources/packages/backend/workflow/test/2026-2027/parttime-assessment/family-count/parttime-assessment-family-size.e2e-spec.ts | Added e2e tests for part-time family size calculation scenarios |
| sources/packages/backend/workflow/test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts | Added e2e tests for full-time family size calculation scenarios |
| sources/packages/backend/workflow/src/workflow-definitions/parttime-assessment-2026-2027.bpmn | Updated part-time workflow to filter out spouse dependants from family size calculation |
| sources/packages/backend/workflow/src/workflow-definitions/load-assessment-consolidated-data.bpmn | Added dependantRelationship field to data mapping |
| sources/packages/backend/workflow/src/workflow-definitions/fulltime-assessment-2026-2027.bpmn | Updated full-time workflow to filter out spouse dependants from family size calculation |
| sources/packages/backend/libs/test-utils/src/models/common.model.ts | Added DependantRelationship enum with relationship types |
| sims.code-workspace | Added "parttime" to spell-check dictionary |
sources/packages/forms/src/form-definitions/sfaa2026-27-pt.json
Outdated
Show resolved
Hide resolved
sources/packages/forms/src/form-definitions/sfaa2026-27-ft.json
Outdated
Show resolved
Hide resolved
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Outdated
Show resolved
Hide resolved
sources/packages/forms/src/form-definitions/sfaa2026-27-pt.json
Outdated
Show resolved
Hide resolved
sources/packages/forms/src/form-definitions/sfaa2026-27-ft.json
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
- tooltip updated
Copilot suggested comment update
Form update
dheepak-aot
reviewed
Jan 30, 2026
...es/packages/backend/workflow/src/workflow-definitions/load-assessment-consolidated-data.bpmn
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
sources/packages/backend/workflow/src/workflow-definitions/fulltime-assessment-2026-2027.bpmn
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/parttime-assessment/family-count/parttime-assessment-family-size.e2e-spec.ts
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
.../test/2026-2027/fulltime-assessment/family-count/fulltime-assessment-family-size.e2e-spec.ts
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
dheepak-aot
reviewed
Jan 30, 2026
sources/packages/forms/src/form-definitions/sfaa2026-27-ft.json
Outdated
Show resolved
Hide resolved
dheepak-aot
reviewed
Jan 30, 2026
- Review Comments
- Form update
|
Backend Unit Tests Coverage Report
|
E2E Workflow Workers Coverage Report
|
E2E Queue Consumers Coverage Report
|
E2E SIMS API Coverage Report
|
dheepak-aot
reviewed
Jan 31, 2026
Comment on lines
+27
to
+29
| const [dependent] = assessmentConsolidatedData.studentDataDependants; | ||
| dependent.relationship = DependantRelationship.Spouse; | ||
| assessmentConsolidatedData.studentDataDependants = [dependent]; |
Collaborator
There was a problem hiding this comment.
This part of code can be removed now by using the factory options this way.
assessmentConsolidatedData.studentDataDependants = [
createFakeStudentDependentEligible(
DependentEligibility.Eligible18To22YearsOldDeclaredOnTaxes,
{ relationship: DependantRelationship.Spouse },
),
];
dheepak-aot
reviewed
Jan 31, 2026
Comment on lines
+45
to
+46
| "Should correctly calculate the family size count when student relationship status is married and one dependant is provided in the application with relationship type spouse " + | ||
| " and not declared on taxes for disability.", |
Collaborator
There was a problem hiding this comment.
There is a space on both the lines, please use the space on one of the lines only.
dheepak-aot
reviewed
Jan 31, 2026
Comment on lines
+58
to
+60
| ]; | ||
| const [dependent] = assessmentConsolidatedData.studentDataDependants; | ||
| dependent.relationship = DependantRelationship.Spouse; |
Collaborator
There was a problem hiding this comment.
dheepak-aot
reviewed
Jan 31, 2026
| }, | ||
| ); | ||
|
|
||
| it( |
Collaborator
There was a problem hiding this comment.
Same double space here.
dheepak-aot
reviewed
Jan 31, 2026
| } from "../../../test-utils/factories"; | ||
|
|
||
| describe(`E2E Test Workflow parttime-assessment-${PROGRAM_YEAR}-family-size.`, () => { | ||
| it("Should correctly calculate the family size count when one or more dependants provided in the application has relationship type 'spouse'.", async () => { |
Collaborator
There was a problem hiding this comment.
Same comments from full-time e2e tests.
dheepak-aot
reviewed
Jan 31, 2026
| "value": "" | ||
| } | ||
| ], | ||
| "content": "<strong>You have identified that your spouse/common-law partner is a disabled dependant. Please make sure you answer \"Yes' to having eligible dependants and add them in the Dependant Information section and ensure you select 'Spouse/common-law partner' as the relationship.</strong>", |
Collaborator
There was a problem hiding this comment.
I see that this text is content and not a header. And the content is not expected to be in a bold text.
Collaborator
There was a problem hiding this comment.
Also the text Yes has double quotes on left and single quote on the right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of this PR, the following were completed:
E2E Test Workflow fulltime-assessment-2026-2027-family-size.
√ Should correctly calculate the family size count when a dependant spouse is selected as the dependant relationship.
√ Should correctly calculate the family size count when an independant spouse is selected as the dependant relationship.
√ Should correctly calculate the family size count when a dependant relationship other than spouse is selected.
E2E Test Workflow parttime-assessment-2026-2027-family-size.
√ Should correctly calculate the family size count when a dependant spouse is selected as the dependant relationship.
√ Should correctly calculate the family size count when an independant spouse is selected as the dependant relationship.
√ Should correctly calculate the family size count when a dependant relationship other than spouse is selected.