PSP-11387 remove the notice of claim if the noc comment/date are not specified.#5286
Open
devinleighsmith wants to merge 2 commits intobcgov:devfrom
Open
PSP-11387 remove the notice of claim if the noc comment/date are not specified.#5286devinleighsmith wants to merge 2 commits intobcgov:devfrom
devinleighsmith wants to merge 2 commits intobcgov:devfrom
Conversation
|
Contributor
|
See CodeCov Report Here: https://app.codecov.io/github/bcgov/psp/pull/5286 |
asanchezr
changed the title
asanchezr
approved these changes
Apr 18, 2026
Collaborator
asanchezr
left a comment
asanchezr
left a comment
There was a problem hiding this comment.
Looks good. See comments
| product: null, | ||
| project: null, | ||
| noticeOfClaim: exists(this.noticeOfClaim) ? [this.noticeOfClaim] : [], | ||
| noticeOfClaim: hasNoticeOfClaim && noticeOfClaim ? [noticeOfClaim] : [], |
Collaborator
There was a problem hiding this comment.
nit:
Suggested change
| noticeOfClaim: hasNoticeOfClaim && noticeOfClaim ? [noticeOfClaim] : [], | |
| noticeOfClaim: hasNoticeOfClaim && exists(noticeOfClaim) ? [noticeOfClaim] : [], |
| toApi(): ApiGen_Concepts_AcquisitionFile { | ||
| const fileProperties = this.properties.map(x => this.toPropertyApi(x)); | ||
| const sortedProperties = applyDisplayOrder(fileProperties); | ||
| const noticeOfClaim: ApiGen_Concepts_NoticeOfClaim | null = this.noticeOfClaim |
| noticeOfClaim: ApiGen_Concepts_NoticeOfClaim; | ||
|
|
||
| toApi(): ApiGen_Concepts_AcquisitionFile { | ||
| const noticeOfClaim: ApiGen_Concepts_NoticeOfClaim | null = this.noticeOfClaim |
Collaborator
There was a problem hiding this comment.
nit: same comments regarding exists()
| comment: yup.string().max(4000, 'Notice of claim comment must be at most ${max} characters'), | ||
| comment: yup | ||
| .string() | ||
| .nullable() |
Collaborator
There was a problem hiding this comment.
I think this nullable validation should be added to AddAcquisitionFileYupSchema.ts as well - right?
| const sortedProperties = applyDisplayOrder(fileProperties); | ||
| const personId = this.responsiblePayer?.personId ?? null; | ||
| const organizationId = !personId ? this.responsiblePayer?.organizationId ?? null : null; | ||
| const noticeOfClaim: ApiGen_Concepts_NoticeOfClaim | null = this.noticeOfClaim |
Collaborator
There was a problem hiding this comment.
same comments re: exists()
Collaborator
There was a problem hiding this comment.
Also AddManagementFormYupSchema needs to be updated with nullable comment field
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.