Add setting to toggle camera jump when selecting items in Contents tab#36
Open
neachi wants to merge 1 commit into
Open
Add setting to toggle camera jump when selecting items in Contents tab#36neachi wants to merge 1 commit into
neachi wants to merge 1 commit into
Conversation
Owner
|
Looks like a pretty simple change. How much was AI involved here? I see the new branch starts with a call to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, selecting an item in the storage's Contents tab forces the camera to jump to the item's location. While this is useful, it can sometimes be frustrating when a player wants to select items to inspect them or build things nearby while keeping the camera focused on a specific area.
This PR introduces a new setting:
Jump camera to selected items(enabled by default to preserve vanilla behavior). When disabled, selecting items from the Contents tab will only select/focus on the item without jumping the camera.Changes
ASF_JumpToItemsOnSelectandASF_JumpToItemsOnSelectDescriptionsettings.ContentsITab.TrySelectAndJump()to select items usingFind.Selectorwithout moving the camera when the setting is disabled.