Repository navigation
Сборка для macOS Intel на Intel-машине - #2
Merged
Merged
Conversation
On the ARM macos-14 runner the x64 Python ran natively as arm64, so the Intel job built a second Apple Silicon app with the same name and the release ended up without the Intel dmg. - macOS Intel builds on macos-15-intel - the dmg is named from the architecture of the built executable (lipo) - the release job checks that all five files exist before publishing Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BAXRzRGWDemk9sYyF2v18g
bboyJohnn
marked this pull request as ready for review
October 19, 2026 17:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Проблема
В релизе v3.0 нет
CineConvert-macos-intel.dmg.Задание «macOS Intel» шло на ARM-машине
macos-14. Python изsetup-pythonсarchitecture: x64там всё равно работал как arm64. В логе это видно по строкамPlatform: macOS-14.8.9-arm64иEXE target arch: arm64. В итоге получилась вторая сборка для Apple Silicon с тем же именем файла, и при слиянии артефактов она заменила первую.Что изменено
macos-15-intel— это настоящая Intel-машина..dmgберётся из архитектуры собранной программы (lipo -archs), а не из машины сборки. Файл теперь не может получить чужое имя.release: до публикации проверяется, что на месте все 5 файлов. Иначе релиз не выходит.Проверка
pyflakes build_release.pyпроходит..dmg, и проходит, когда есть все пять.Generated by Claude Code