Skip to content

Remove text about 404 if label not set#186

Open
samdbmg wants to merge 1 commit intomainfrom
sammg/fix/label-not-required
Open

Remove text about 404 if label not set#186
samdbmg wants to merge 1 commit intomainfrom
sammg/fix/label-not-required

Conversation

@samdbmg
Copy link
Copy Markdown
Member

@samdbmg samdbmg commented Apr 17, 2026

Details

404 would indicate the resource was not found, but in this case it was found, it just had no value.
Aligns with the other requests (e.g. GET /flows/{flowID}/description

I've put this as bugfix, although I can see at least one implementation that implements the behaviour as described, so I'd appreciate a second opinion on whether it's an API break

Jira Issue (if relevant)

Jira URL: N/A

Related PRs

N/A

Submitter PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • API version has been incremented if necessary
  • ADR status has been updated, and ADR implementation has been recorded
  • Documentation updated (README, etc.)
  • PR added to Jira Issue (if relevant)
  • Follow-up stories added to Jira

Reviewer PR Checks

(tick as appropriate)

  • PR completes task/fixes bug
  • Design makes sense, and fits with our current code base
  • Code is easy to follow
  • PR size is sensible
  • Commit history is sensible and tidy

Info on PRs

The checks above are guidelines. They don't all have to be ticked, but they should all have been considered.

404 would indicate the resource was not found, but in this case it was
found, it just had no value.
Aligns with the other requests (e.g. `GET /flows/{flowID}/description`

sem-ver: bugfix
@samdbmg samdbmg requested a review from a team as a code owner April 17, 2026 15:02
Copy link
Copy Markdown
Contributor

@j616 j616 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've put this as bugfix, although I can see at least one implementation that implements the behaviour as described, so I'd appreciate a second opinion on whether it's an API break

We generally consider version bumps from the perspective of the client. With that in mind, I think I'd consider it a feature bump at most. But I think it's a bit moot given the next release will be a minor release anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants