Open
Conversation
added 2 commits
February 29, 2016 22:11
TINYINT is mapped to NUMBER, and all of the types mapped to DB API type are assigned to a conversion function.
DB API 2.0 suggests using the datetime module to represent dates and times. Note that parsing the java value string is ~2x faster than 1) using datetime.datetime.strptime on java_val.toString() and 2) constructing datetime.datetime directory with java_val.getYear(), java_val.getMonth(), etc.
|
I also ran into issue with Any way there is a simple workaround. You can just remove |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have included a few more data types to the
_DEFAULT_CONVERTERSdictionary. All of these were already mapped inDBAPITypeObject, except for TINYINT, which is new.I also altered
_to_datetime,_to_date, and_to_timeto return objects from thedatetimemodule instead of strings. This behavior seems to be more consistent with the DB API 2.0 spec.I have to admit that I tried following the README_development.rst instructions to run the tests, but I ran into issues at the
jip installsteps that prevented me from doing so. I hope this doesn't cause too much of a problem.