Repository navigation
Restore feature_configuration argument to derive_swift_module_name - #1907
Merged
brentleyjones merged 1 commit intoOct 2, 2026
Conversation
brentleyjones
marked this pull request as ready for review
September 21, 2026 14:47
brentleyjones
requested review from
aaronsky,
adincebic,
keith and
luispadron
as code owners
September 21, 2026 14:47
brentleyjones
enabled auto-merge (squash)
September 21, 2026 14:48
adincebic
reviewed
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the optional
feature_configurationkeyword argument accepted byderive_swift_module_namein 4.0.1 and 4.1.0. Its removal in #1903 breaks existing callers even though the argument is currently unused.Keep the argument as a no-op with an explicit
unused-variablesuppression, and regenerate the API documentation. This preserves compatibility for the next patch release.