Resolve system SDK path via xcrun in explicit-modules scan - #1902
Merged
Merged
Conversation
The scanner assumed an unversioned SDK symlink (e.g. MacOSX.sdk) exists under each platform's SDKs directory. That symlink is not guaranteed to be present in every Xcode layout, causing scanning to fail with FileNotFoundError. Ask xcrun for the resolved SDK path instead, failing loudly if it cannot be determined.
ma-oli
requested review from
aaronsky,
adincebic,
brentleyjones,
keith and
luispadron
as code owners
September 16, 2026 08:52
aaronsky
approved these changes
Sep 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The scanner assumed an unversioned SDK symlink (e.g. MacOSX.sdk) exists under each platform's SDKs directory. That symlink is not guaranteed to be present in every Xcode layout, causing scanning to fail with FileNotFoundError.
Ask xcrun for the resolved SDK path instead, failing loudly if it cannot be determined.