Skip to content

add deprecate annotation - #261

Merged
bergsieker merged 1 commit into
bazelbuild:mainfrom
sluongng:sluongng/deprecate-annotation
Jun 13, 2023
Merged

add deprecate annotation#261
bergsieker merged 1 commit into
bazelbuild:mainfrom
sluongng:sluongng/deprecate-annotation

Conversation

@sluongng

@sluongng sluongng commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator

This helps signal to downstream API consumers, via code gen results,
that the fields are deprecated and their usage is discouraged.

@sluongng
sluongng requested a review from bergsieker as a code owner June 9, 2023 09:04
@sluongng

sluongng commented Jun 9, 2023

Copy link
Copy Markdown
Collaborator Author

depends on #260 as it might affect the Go code gen result.

@EdSchouten EdSchouten mentioned this pull request Jun 9, 2023
@bergsieker

Copy link
Copy Markdown
Contributor

@sluongng can you update this now that #260 has been merged?

@sluongng
sluongng force-pushed the sluongng/deprecate-annotation branch from 58a69f7 to d3ddb45 Compare June 13, 2023 08:11
@sluongng

Copy link
Copy Markdown
Collaborator Author

Rebased 🙏

@bergsieker
bergsieker merged commit eafa1b0 into bazelbuild:main Jun 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants