[8.8.0] Support bounded parallel chunk transfers - #29873
Conversation
87d9fb7 to
1f31e78
Compare
|
@sluongng Could you please resolve the conflict? |
The 8.8.0 cherry-pick tracked by bazelbuild#29870 is needed because users enabling `--experimental_remote_cache_chunking` can still see large CDC blobs transfer chunks serially on this release branch. Backport bazelbuild#29341 so chunked uploads and downloads use a bounded per-blob sliding window while existing remote cache connection limits continue to bound global RPC concurrency. The 8.8.0 branch does not have the newer `GrpcCacheClient.shouldVerifyDownloads()` helper or the split remote Java BUILD targets. Wire whole-blob verification through `RemoteOptions.remoteVerifyDownloads` and keep the benchmark on this branch's coarse remote target layout. Refs bazelbuild#29870. PiperOrigin-RevId: 919144974 Change-Id: Iaa0ca8971bd21c879f21c708327b5ddd837ecf1f (cherry picked from commit 084958b)
Head branch was pushed to by a user without write access
1f31e78 to
de0efee
Compare
|
Merge conflict is resolved. I don't think the remaining CI failure is related to this PR: the only failing check is |
|
@iancha1992 do you need anything else from my end for this? |
|
@tjgq would you be able to review this? Thanks! |
|
hmm should I rebase the branch or you can start the merge queue on your side @iancha1992 Im not familiar with the cherr-pick CI setup |
|
@iancha1992 The build on the merge queue says it needs approval to proceed. |
|
@iancha1992 It seems like someone needs to approve the CI build to start once its running in the merge queue. |
@tyler-french Yes, we are aware and on it to fix this currently. |
2cd0c53
|
Wooo! Great job getting the merge queue fixed! |


Fixes #29870.
This cherry-picks #29341 to release-8.8.0 because users enabling
--experimental_remote_cache_chunkingcan still see large CDC blobs transfer chunks serially on this release branch. The backport lets chunked uploads and downloads use a bounded per-blob sliding window while existing remote cache connection limits continue to bound global RPC concurrency.The 8.8.0 branch does not have the newer
GrpcCacheClient.shouldVerifyDownloads()helper or the split remote Java BUILD targets. This backport wires whole-blob verification throughRemoteOptions.remoteVerifyDownloadsand keeps the benchmark on this branch's coarse remote target layout.