Skip to content

[8.8.0] Support bounded parallel chunk transfers - #29873

Merged
iancha1992 merged 1 commit into
bazelbuild:release-8.8.0from
sluongng:sluongng/cherry-pick-29341-8.8.0
Jul 10, 2026
Merged

[8.8.0] Support bounded parallel chunk transfers#29873
iancha1992 merged 1 commit into
bazelbuild:release-8.8.0from
sluongng:sluongng/cherry-pick-29341-8.8.0

Conversation

@sluongng

Copy link
Copy Markdown
Contributor

Fixes #29870.

This cherry-picks #29341 to release-8.8.0 because users enabling --experimental_remote_cache_chunking can still see large CDC blobs transfer chunks serially on this release branch. The backport lets chunked uploads and downloads use a bounded per-blob sliding window while existing remote cache connection limits continue to bound global RPC concurrency.

The 8.8.0 branch does not have the newer GrpcCacheClient.shouldVerifyDownloads() helper or the split remote Java BUILD targets. This backport wires whole-blob verification through RemoteOptions.remoteVerifyDownloads and keeps the benchmark on this branch's coarse remote target layout.

@sluongng
sluongng force-pushed the sluongng/cherry-pick-29341-8.8.0 branch from 87d9fb7 to 1f31e78 Compare June 17, 2026 12:42
@sluongng
sluongng marked this pull request as ready for review June 17, 2026 12:54
@sluongng
sluongng requested a review from a team as a code owner June 17, 2026 12:54
@github-actions github-actions Bot added team-Remote-Exec Issues and PRs for the Execution (Remote) team awaiting-review PR is awaiting review from an assigned reviewer labels Jun 17, 2026
@iancha1992
iancha1992 enabled auto-merge June 17, 2026 18:11
@iancha1992
iancha1992 requested review from coeuvre and tjgq June 17, 2026 18:12
@iancha1992

Copy link
Copy Markdown
Member

@sluongng Could you please resolve the conflict?

The 8.8.0 cherry-pick tracked by bazelbuild#29870 is needed because users
enabling `--experimental_remote_cache_chunking` can still see large
CDC blobs transfer chunks serially on this release branch. Backport
bazelbuild#29341 so chunked uploads and downloads use a bounded
per-blob sliding window while existing remote cache connection limits
continue to bound global RPC concurrency.

The 8.8.0 branch does not have the newer
`GrpcCacheClient.shouldVerifyDownloads()` helper or the split remote
Java BUILD targets. Wire whole-blob verification through
`RemoteOptions.remoteVerifyDownloads` and keep the benchmark on this
branch's coarse remote target layout.

Refs bazelbuild#29870.

PiperOrigin-RevId: 919144974
Change-Id: Iaa0ca8971bd21c879f21c708327b5ddd837ecf1f
(cherry picked from commit 084958b)
auto-merge was automatically disabled June 27, 2026 12:01

Head branch was pushed to by a user without write access

@sluongng
sluongng force-pushed the sluongng/cherry-pick-29341-8.8.0 branch from 1f31e78 to de0efee Compare June 27, 2026 12:01
@sluongng

Copy link
Copy Markdown
Contributor Author

Merge conflict is resolved.

I don't think the remaining CI failure is related to this PR: the only failing check is windows-windows-shard-3, where //src/test/java/com/google/devtools/build/lib/skyframe:SourceDirectoryIntegrationTest timed out. The rest of the Buildkite presubmit shards are passing.

@sluongng

Copy link
Copy Markdown
Contributor Author

@iancha1992 do you need anything else from my end for this?

@tyler-french

Copy link
Copy Markdown
Contributor

@tjgq would you be able to review this? Thanks!

@iancha1992
iancha1992 enabled auto-merge June 29, 2026 18:32

@tjgq tjgq left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cherry-picking!

@iancha1992
iancha1992 added this pull request to the merge queue Jul 8, 2026
@tjgq tjgq added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Jul 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 8, 2026
@sluongng

sluongng commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

hmm should I rebase the branch or you can start the merge queue on your side @iancha1992

Im not familiar with the cherr-pick CI setup

@iancha1992
iancha1992 added this pull request to the merge queue Jul 8, 2026
@iancha1992 iancha1992 removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Jul 8, 2026
@tyler-french

Copy link
Copy Markdown
Contributor

@iancha1992 The build on the merge queue says it needs approval to proceed.

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 8, 2026
@iancha1992
iancha1992 added this pull request to the merge queue Jul 8, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Jul 9, 2026
@tyler-french

Copy link
Copy Markdown
Contributor

@iancha1992 It seems like someone needs to approve the CI build to start once its running in the merge queue.
It shows this error:
Screenshot 2026-07-08 at 2 35 34 PM

@iancha1992

Copy link
Copy Markdown
Member

@iancha1992 It seems like someone needs to approve the CI build to start once its running in the merge queue. It shows this error: Screenshot 2026-07-08 at 2 35 34 PM

@tyler-french Yes, we are aware and on it to fix this currently.

@iancha1992
iancha1992 added this pull request to the merge queue Jul 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 9, 2026
@iancha1992
iancha1992 added this pull request to the merge queue Jul 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 9, 2026
@iancha1992
iancha1992 added this pull request to the merge queue Jul 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 9, 2026
@iancha1992
iancha1992 added this pull request to the merge queue Jul 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 9, 2026
@iancha1992
iancha1992 added this pull request to the merge queue Jul 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 9, 2026
@iancha1992
iancha1992 added this pull request to the merge queue Jul 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 9, 2026
@iancha1992
iancha1992 added this pull request to the merge queue Jul 10, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jul 10, 2026
@iancha1992
iancha1992 added this pull request to the merge queue Jul 10, 2026
Merged via the queue into bazelbuild:release-8.8.0 with commit 2cd0c53 Jul 10, 2026
46 checks passed
@sluongng

Copy link
Copy Markdown
Contributor Author

Wooo! Great job getting the merge queue fixed!

@sluongng
sluongng deleted the sluongng/cherry-pick-29341-8.8.0 branch July 10, 2026 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-Remote-Exec Issues and PRs for the Execution (Remote) team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants